Skip to content

Fix: uv sync cause error due to mmcv#8

Merged
linkedlist771 merged 1 commit into
mainfrom
mmcv-uv-sync-fix
Mar 26, 2026
Merged

Fix: uv sync cause error due to mmcv#8
linkedlist771 merged 1 commit into
mainfrom
mmcv-uv-sync-fix

Conversation

@linkedlist771

@linkedlist771 linkedlist771 commented Mar 26, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes the uv sync failure caused by mmcv, related to #5.

This PR adjusts the dependency setup to avoid the current mmcv installation problem during uv sync, so the project environment can be created successfully.

Changes

  • updated dependency configuration to work around the current mmcv issue
  • made uv sync complete successfully in the local development environment

Notes

This is a temporary fix.

Because of the mmcv version / API differences, docker compose may still fail to run correctly. That compatibility issue is not fully resolved in this PR and will need to be handled in a follow-up update.

Related

Summary by CodeRabbit

  • Chores

    • Updated core dependencies: replaced mmcv-full with mmcv and mmengine for improved architecture compatibility.
    • Extended .gitignore to exclude additional system and lock files.
    • Added build-time dependency constraints for enhanced package installation control.
  • Bug Fixes

    • Improved error handling in feature propagation module with more detailed exception information.

@linkedlist771 linkedlist771 merged commit 7059b4a into main Mar 26, 2026
0 of 3 checks passed
@coderabbitai

coderabbitai Bot commented Mar 26, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 80cb52d0-fb0d-41cd-b25b-35ab1ff65dc8

📥 Commits

Reviewing files that changed from the base of the PR and between f48bb82 and 83c92ed.

📒 Files selected for processing (4)
  • .gitignore
  • pyproject.toml
  • src/demark_world/models/model/modules/feat_prop.py
  • src/demark_world/models/model/modules/flow_comp.py

📝 Walkthrough

Walkthrough

This PR updates the project's dependency management by migrating from mmcv-full to separate mmcv and mmengine packages with pinned versions, adds build-time setuptools constraints via a new [tool.uv.extra-build-dependencies] section, and updates corresponding import statements across modules to reference the new dependency sources.

Changes

Cohort / File(s) Summary
Configuration & Dependency Updates
.gitignore, pyproject.toml
Extends .gitignore with .DS_Store and uv.lock. Replaces mmcv-full>=1.7.2 with mmcv>=2.0.0,<2.3.0 and mmengine>=0.10,<0.11. Adds new [tool.uv.extra-build-dependencies] section pinning setuptools<82 for clip and mmcv build-time requirements.
Import Path Updates
src/demark_world/models/model/modules/feat_prop.py, src/demark_world/models/model/modules/flow_comp.py
Updates import sources to match new dependency structure: mmcv.cnn.constant_initmmengine.model.constant_init and mmcv.runner.load_checkpointmmengine.runner.load_checkpoint. Refines exception handling in feat_prop.py with more specific except Exception clause and removes duplicate fallback implementations.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Poem

🐰 A migration tale, so grand and bright,
From mmcv-full to engines of light,
With setuptools pinned and imports all true,
Dependencies dance in versions anew!
The uv sync shall flow, no pkg_resources fright,
Our warren's rebuilt—dependencies tight! 🔧

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mmcv-uv-sync-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when installing modules with uv sync command

1 participant