[Task] VX-261: Show uid when get the pod in prometheus#241
Open
WakeupTsai wants to merge 1 commit intodevelopfrom
Open
[Task] VX-261: Show uid when get the pod in prometheus#241WakeupTsai wants to merge 1 commit intodevelopfrom
WakeupTsai wants to merge 1 commit intodevelopfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #241 +/- ##
===========================================
+ Coverage 78.38% 78.39% +<.01%
===========================================
Files 50 50
Lines 2484 2485 +1
===========================================
+ Hits 1947 1948 +1
Misses 415 415
Partials 122 122
Continue to review full report at Codecov.
|
hwchiu
approved these changes
Aug 13, 2018
John-Lin
approved these changes
Aug 13, 2018
Contributor
|
我們這個晚一點合併?因為我是傾向使用官方image我們不維護image |
Contributor
|
官方若不接受,我們就自己維護囉,這邊給個一兩天看看官方要不要收 |
Contributor
Author
Contributor
|
@WakeupTsai 你可以先發一個 Issue問他說,想要看到 pod的UUID 可不可以發PR進去 |
Contributor
|
conflicts |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.