From 9990bd0bb75bd38520394bdf5b7d6f9860611f50 Mon Sep 17 00:00:00 2001 From: Cas Lubbers Date: Wed, 4 Mar 2026 16:12:30 +0100 Subject: [PATCH] fix: remove otomi.git.password from settings endpoint --- src/api/v1/settings.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/api/v1/settings.ts b/src/api/v1/settings.ts index b6e1d5aaa..1e85726ef 100644 --- a/src/api/v1/settings.ts +++ b/src/api/v1/settings.ts @@ -1,5 +1,6 @@ import Debug from 'debug' import { Response } from 'express' +import { omit } from 'lodash' import { OpenApiRequestExt } from 'src/otomi-models' const debug = Debug('otomi:api:v1:settings') @@ -15,10 +16,7 @@ export const getSettings = (req: OpenApiRequestExt, res: Response): void => { debug(`getSettings(${idsArray})`) const v = req.otomi.getSettings(idsArray) if (v?.otomi) { - const { otomi: otomiSettings, ...restSettings } = v - // Remove the otomi.adminPassword from otomi settings response - const { adminPassword, ...restOtomiSettings } = otomiSettings - res.json({ ...restSettings, otomi: restOtomiSettings }) + res.json(omit(v, ['otomi.adminPassword', 'otomi.git.password'])) } else { res.json(v) }