Skip to content

Commit 95306b4

Browse files
committed
blktests: fix diy output in oscheck run task
The diy callback plugin was throwing warnings about undefined 'cmd' attribute because the template attempted to access command information through ansible_callback_diy.result.output.cmd, which doesn't exist for ansible.builtin.command modules. Fixed by using ansible_callback_diy.task.args._raw_params to access the actual command being executed, and replaced ansible_host with inventory_hostname for proper variable scope in the callback context. Debugging with the following vars helped finding the root cause: ansible_callback_diy_runner_on_ok_msg: | DEBUG - Result keys: {{ ansible_callback_diy.result.output.keys() | list }} DEBUG - Task args: {{ ansible_callback_diy.task.args }} DEBUG - Direct keys: {{ ansible_callback_diy.keys() | list }} $ {{ ansible_callback_diy.task.args._raw_params | default('command') }} {{ stdout | default('') }} Output: TASK: Run blktests using oscheck.sh [dgc-testing-block,dgc-testing-nvme] DEBUG - Result keys: ['changed', '_ansible_no_log', 'censored'] DEBUG - Task args: {'chdir': '/usr/local/blktests/', '_raw_params': './oscheck.sh --print-start --print-done --test-group block block/003'} DEBUG - Direct keys: ['playbook', 'play', 'task', 'result', 'top_level_var_names'] $ ./oscheck.sh --print-start --print-done --test-group block block/003 DEBUG - Result keys: ['changed', '_ansible_no_log', 'censored'] DEBUG - Task args: {'chdir': '/usr/local/blktests/', '_raw_params': './oscheck.sh --print-start --print-done --test-group nvme block/003'} DEBUG - Direct keys: ['playbook', 'play', 'task', 'result', 'top_level_var_names'] $ ./oscheck.sh --print-start --print-done --test-group nvme block/003 Generated-by: Claude AI Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
1 parent 0f7daa6 commit 95306b4

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

playbooks/roles/blktests/tasks/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -364,9 +364,9 @@
364364

365365
- name: Run blktests using oscheck.sh
366366
vars:
367-
group: "{{ ansible_host | regex_replace('blktests-') | regex_replace(kdevops_host_prefix + '-') | regex_replace('-dev') | regex_replace('-', '_') }}"
367+
group: "{{ inventory_hostname | regex_replace('blktests-') | regex_replace(kdevops_host_prefix + '-') | regex_replace('-dev') | regex_replace('-', '_') }}"
368368
ansible_callback_diy_runner_on_ok_msg: |
369-
$ {{ ansible_callback_diy.result.output.cmd | join(' ') }}
369+
$ {{ ansible_callback_diy.task.args._raw_params | default('command') }}
370370
{{ ansible_callback_diy.result.output.stdout | default('') }}
371371
tags: ["blktests", "run_tests"]
372372
become: true

0 commit comments

Comments
 (0)