File browser plugin: New files filtered out by default

[Khazbs]

Description

The file browser plugin doesn't list empty files by default, as the "Show Binary" option in "Filters" is off by default. Because of this, when creating files using the "New File" command in the file browser plugin, I get the following error:

The new file is currently filtered out. You need to adjust your filter settings to make the file visible

After enabling the "Show Binary" option, empty files are listed. I don't think such default behavior is particularly beginner-friendly.

Steps to reproduce

1. Start xed;
2. Open the side pane file browser;
3. In the file browser's context menu, open "Filters" and ensure "Show Binary" is as unchecked as it is by default;
4. In some directory, use the file browser's "New File" command to create a new file.

Actual result

• An alert appears: "The new file is currently filtered out. You need to adjust your filter settings to make the file visible";
• The new file is not visible in the file browser.

Expected result

• The new file created through the file browser should be visible with default settings.

Possible solutions

• Don't make new files empty, put a newline in them;
• Don't assume empty files to fall into the "Binary" category;
• Enable "Show Binary" by default.

Not sure which is preferable.

Environment

• xed 3.8.4
• Cinnamon 6.4.13
• Linux Mint Debian Edition 7 (Gigi)

[DHager]

Just discovered the exact same thing the hard way, finding this issue after finding the cause. (Xed 3.8.4, Linux Mint Cinnamon 22.)

Don't assume empty files to fall into the "Binary" category

I prefer the above fix.

True, it may tempt users into editing a totally blank file that they should never have touched... But that seems like a lesser-hazard than somehow getting into a state where every new file is an error message.

It also means that externally-created files the human user already considers "non-binary" (like a blank readme.txt) will show up as expected.

[Khazbs]

I agree. As a user, I do lean towards this fix too, I think an empty file is just as good of a text file as it is a binary file.

As for safeguarding the user from unintentionally editing some special empty files, I think the hidden files filter already does a good job at that, I don't remember any special empty files that are not hidden, so I don't expect this to be of big concern.