What would success / a fix look like?
while it will be difficult, we should try to add some unit / regression tests to the codebase to catch issues before they're introduced. this includes including mock payloads from GitHub/gitlab in a variety of scenarios
- an end-to-end test would be extremely cumbersome to implement, we will add test coverage by validating that GitHub/gitlab payloads are following our logic (ex: draft PRs are skipped). we'll mock the incoming payloads and verify that any outgoing requests match the format we expect
- gitlab/github may change their APIs, so we should have a scheduled test that exercises the methods in each client to GitHub.com/gitlab.com and verify we get the expected response
the gitlab+github clients/auth files are not tested in the unit tests but this is an opportunity for integration tests
What would success / a fix look like?
while it will be difficult, we should try to add some unit / regression tests to the codebase to catch issues before they're introduced. this includes including mock payloads from GitHub/gitlab in a variety of scenarios
the gitlab+github clients/auth files are not tested in the unit tests but this is an opportunity for integration tests