fix: accept port 0 in JSON config (ephemeral port support)#3895
Merged
Conversation
The fieldPairs-driven JSON parser in createWaku delegated Port fields to confutils's parseCmdArg, which rejects 0 and forces every consumer to pin a fixed port. Special-case Port fields here so port 0 is accepted and propagated to the libp2p / discv5 bind path, where the OS assigns an ephemeral port. Refs: logos-co/logos-delivery-module#18 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
You can find the image built from this PR at Built from 4a8c45d |
Now that confutils accepts port 0 in parseCmdArg (status-im/nim-confutils#146), revert the local Port special-case in createWaku and bump confutils to the fix instead. confutils is temporarily pinned to the PR fork commit (igor-sirotin/nim-confutils@0292f00d) until #146 merges to status-im master. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Bring branch up to date with master (clears nimble-not-behind-tag).
status-im/nim-confutils#146 is merged; move the confutils pin from the PR fork back to status-im/nim-confutils master (36f3115). Content is identical to the fork commit, so nimble sha1 and nix sha256 are unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
fcecin
approved these changes
May 21, 2026
Ivansete-status
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump
confutilsto include:Needed to run multiple module instances on one host (logos-co/logos-delivery-module#18).