Question: does the test suite need to create, start and stop Rumbster each time?

[guyboertje]

Does the current impl impact test suite performance?

Consider using a suite wide set for Rumbster and simply clear the messages from the MailMessageObserver instance before each test.

e.g.

def message_observer
  @observer ||= MailMessageObserver.new
end

def rumpster
  @rumpster ||= begin
    inst = Rumbster.new(port)
    inst.add_observer message_observer
    inst.start
    inst
  end
end

describe "outputs/email" do

  let(:plugin)            { LogStash::Plugin.lookup("output", "email") }

  before :each do
    message_observer.messages.clear
  end

  after :suite do
    rumpster.stop
  end

  # rest of tests here

end

[purbon]

short and simple, no, this should be a target of a soon test refactor here. Thanks for raising this issue.

[guyboertje]

You are welcome.