Skip to content

Some C functions have return values for no (apparently) good reason #2

Description

@d-lamb

There are several C functions that modify a world or a fluxon or a vertex by getting a pointer to that object. And then they return '0' always. It is not clear whether this is intentional--are the 0's used as status checks?--or accidental.

To find these instances do:

cd lib
grep --exclude='*.cf.c' 'return 0;' *

If these return values are never used then probably the return value should be dropped and the functions changed to void return type instead of int, long, or NUM.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions