Type info is not working correctly

[rvion]

I made a PR (#7) that picked the right type info to show, but the feature doesn't seem to work anymore

Now

Before

Exemple 1 :

Example 2:

related code was:

   def filter_enclosing(_,from_col, to_col, from_line, to_line, spans):
       return [span for span in spans if 
           (   ((span[1].get("spanFromLine")<from_line) or 
               (span[1].get("spanFromLine") == from_line and
                span[1].get("spanFromColumn") <= from_col))
           and ((span[1].get("spanToLine")>to_line) or 
               (span[1].get("spanToLine") == to_line and
                span[1].get("spanToColumn") >= to_col))
           )]

[type_string, type_span] = self.filter_enclosing(
                from_col_+1, to_col_+1,
                from_line_+1, to_line_+1,
                types)[0]

[tomv564]

Ah this is my bad.. I thought stack ide already considered the selection when returning results but seeing this it obviously doesn't. I'll restore the old logic shortly!

[tomv564]

Should be fixed, @rvion can you let me know otherwise? Thanks!

[rvion]

Wow, fast, thank you !
I'll reopen if it's not working :)

[rvion]

it doesn't seem to be working

[rvion]

the function filter_enclosing doens't seem to do the same thing as your modification

   def filter_enclosing(_,from_col, to_col, from_line, to_line, spans):
       return [span for span in spans if 
           (   ((span[1].get("spanFromLine")<from_line) or 
               (span[1].get("spanFromLine") == from_line and
                span[1].get("spanFromColumn") <= from_col))
           and ((span[1].get("spanToLine")>to_line) or 
               (span[1].get("spanToLine") == to_line and
                span[1].get("spanToColumn") >= to_col))
           )]

[rvion]

ping @tomv564

[tomv564]

Can you make sure your Sublime is running the latest code?

The filter_enclosing function should work the same, but could also use some tests (and it wouldn't be the first time I misunderstood it!). Instead of comparing line and column together it translates everything to Region objects and compares those.

[rvion]

Yes, I'm running the latest code:

$ git log --pretty=oneline --abbrev-commit -5
10d0a28 Merge pull request #33 from tomv564/fix_reset_stackide
9c43b83 remove settings from reset call, fix restart command
f531149 Correct other-modules and offer config example
2630a43 Merge pull request #27 from tomv564/fix_selection_type_info
3f479aa fix show selection type functionality

but there is still a problem for me:

my guess is that we have a different version of either

• stack (stack --version: 0.1.7.0, Git revision 14236a4f1cb349fd0a6870a2a78bbe182dd9565a x86_64) (last version as of today)
• stack-ide (stack-ide --version: 0.1.0.0, Git revision 9d0e22e22bba2945f5d437490255c81a336d80ef (174 commits) X86_64)
• sublime-text:
  

[rvion]

just updated everything to the latests versions, and still have the problem:

Are you on linux ?
I'm on mac, difference may be there:

$ uname -a 
Darwin MacBook-Air-de-rvion.local 14.5.0 Darwin Kernel Version 14.5.0: Wed Jul 29 02:26:53 PDT 2015; root:xnu-2782.40.9~1/RELEASE_X86_64 x86_64

[rvion]

found the bug :)

/cc @tomv564

I have the automatic popup feature enabled:

And when I hover some code, the automatic type popup is wrong:

But when I hit Cmd+T (as you did to test the feature), it is correct

this is because in https://github.com/lukexi/stack-ide-sublime/blob/master/win.py#L43-L50, there is a duplicated code branch that is wrong:

        types = list(parse_exp_types(exp_types))
        if types:
            # Display the first type in a region and in the status bar
            view = self.window.active_view()
            (type, span) = types[0]
            if span:
                if Win.show_popup:
                    view.show_popup(type)