Skip to content

[Product Reviews] Fix pagination  #462

@magento-engcom-team

Description

@magento-engcom-team

During iteration product reviews the last element should return "null" for cursor value.

Steps to reproduce:

  • Create 2 approved product reviews
  • Start iterate over reviews with pagination size "1"
  • call ProductReviews.getProductReviews method with gRPC UI
  • with received cursor value from the previous call send new request to getProductReviews

Expected results:

  • after 2nd call, cursor should have "null" value

Actual result:

  • cursor is not null, send request with given cursor value to getProductReviews will return empty result

repo: https://github.com/magento/storefront-product-reviews-ce/

 

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions