From 924dda62f08da6386c057f52ebb09ce49d1ffc3b Mon Sep 17 00:00:00 2001 From: MadMax Date: Wed, 22 Jul 2026 19:54:14 +0100 Subject: [PATCH] fix(mop): default Group::SetTargetIcon context arg so pre-MoP callers compile The 5.4.8 group-markers restore (6b7978ec9) added a required `uint8 context` parameter to Group::SetTargetIcon, breaking every 3-argument caller -- notably the shared Eluna Group:SetTargetIcon binding (build error C2660). Give the new parameter a default of 0 (a normal target-icon set) so existing 3-arg callers stay source-compatible and no Eluna change is needed. Builds clean against stock Eluna (fd0b208a); 218/218 tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) --- src/game/WorldHandlers/Group.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/game/WorldHandlers/Group.h b/src/game/WorldHandlers/Group.h index 8b5deabfd..7fdc741b7 100644 --- a/src/game/WorldHandlers/Group.h +++ b/src/game/WorldHandlers/Group.h @@ -1063,8 +1063,10 @@ class Group } } + // context defaults to 0 (a normal target-icon set) so pre-MoP 3-argument callers -- + // notably Eluna's shared Group:SetTargetIcon binding -- stay source-compatible. void SetTargetIcon(uint8 id, ObjectGuid whoGuid, ObjectGuid targetGuid, - uint8 context); + uint8 context = 0); Difficulty GetDifficulty(bool isRaid) const { return isRaid ? m_raidDifficulty : m_dungeonDifficulty; } Difficulty GetDungeonDifficulty() const { return m_dungeonDifficulty; }