Follow-up from code review on the MCP server feature (#50).
Two operational hygiene items.
- Duplicate
TASKLOG_API_URL source of truth (mcp/src/api-client.ts:13 vs mcp/src/config.ts:19). api-client.ts reads process.env.TASKLOG_API_URL directly with its own default; config.ts already exposes config.tasklogApiUrl with the same default. If the default in config.ts changes, the api-client keeps the old value silently. Import config and drop the local constant.
- No SIGTERM handler in the MCP server (
mcp/src/server.ts). runit sends TERM on stop; we don't close the SQLite handle cleanly. Add process.on('SIGTERM', () => { db.close(); process.exit(0); }) and similar for the HTTP server.
Source: review of feature/mcp-server-#50.
Follow-up from code review on the MCP server feature (#50).
Two operational hygiene items.
TASKLOG_API_URLsource of truth (mcp/src/api-client.ts:13vsmcp/src/config.ts:19). api-client.ts readsprocess.env.TASKLOG_API_URLdirectly with its own default; config.ts already exposesconfig.tasklogApiUrlwith the same default. If the default in config.ts changes, the api-client keeps the old value silently. Importconfigand drop the local constant.mcp/src/server.ts). runit sends TERM on stop; we don't close the SQLite handle cleanly. Addprocess.on('SIGTERM', () => { db.close(); process.exit(0); })and similar for the HTTP server.Source: review of feature/mcp-server-#50.