From 8bb61e95ab38622eb7bbca01acd0407a70332495 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 17 Sep 2026 12:15:55 +0200 Subject: [PATCH 1/3] npm v12 dropped support for the `--msvs_version` option Comment out npm --msvs_version on Windows. --- test/run.util.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/test/run.util.js b/test/run.util.js index 55e50b13..a4367a50 100644 --- a/test/run.util.js +++ b/test/run.util.js @@ -58,10 +58,11 @@ function run(prog, command, args, app, opts, cb) { opts.cwd = path.join(__dirname, app.name); } + // npm v12 dropped support for the `--msvs_version` option. // Test building with msvs 2022 - if (process.platform === 'win32') { - final_cmd += ' --msvs_version=2022 '; - } + // if (process.platform === 'win32') { + // final_cmd += ' --msvs_version=2022 '; + //} // finish appending all arguments final_cmd += ' ' + app.args; From b8ca42b1ad131aa30c7844f51399b82e293d65cc Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 17 Sep 2026 13:06:47 +0200 Subject: [PATCH 2/3] Remove commented code for msvs_version option --- test/run.util.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/run.util.js b/test/run.util.js index a4367a50..067ad055 100644 --- a/test/run.util.js +++ b/test/run.util.js @@ -62,7 +62,7 @@ function run(prog, command, args, app, opts, cb) { // Test building with msvs 2022 // if (process.platform === 'win32') { // final_cmd += ' --msvs_version=2022 '; - //} + // } // finish appending all arguments final_cmd += ' ' + app.args; From 37674826e04b3804719eba8597ae955da58aace6 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 17 Sep 2026 13:22:06 +0200 Subject: [PATCH 3/3] Fix comments for clarity and consistency --- test/run.util.js | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/test/run.util.js b/test/run.util.js index 067ad055..0f648338 100644 --- a/test/run.util.js +++ b/test/run.util.js @@ -28,9 +28,9 @@ function run(prog, command, args, app, opts, cb) { // here we add the program and the command let final_cmd = prog + ' ' + command; - // if we are calling out to `node-pre-gyp` let's ensure we directly - // call the local version at a relative path (to avoid the change) we might - // use some external version on PATH + // if we are calling out to `node-pre-gyp`, let's ensure we directly + // call the local version at a relative path (to avoid the change) + // we might use some external version on PATH if (final_cmd.indexOf('node-pre-gyp') > -1) { final_cmd = cmd_path + final_cmd; if (opts.npg_debug) { @@ -53,23 +53,17 @@ function run(prog, command, args, app, opts, cb) { } } - // unless explicitly provided, lets execute the command inside the app specific directory + // unless explicitly provided, let's execute the command inside the app-specific directory if (!opts.cwd) { opts.cwd = path.join(__dirname, app.name); } - // npm v12 dropped support for the `--msvs_version` option. - // Test building with msvs 2022 - // if (process.platform === 'win32') { - // final_cmd += ' --msvs_version=2022 '; - // } - // finish appending all arguments final_cmd += ' ' + app.args; final_cmd += ' ' + args; - // On unix we want to display compile args (rather than have them hidden) + // On Unix we want to display compile args (rather than have them hidden) // for easier debugging of unexpected compile failures. // We do this by pre-pending the magic variable that make responds to. if (process.platform !== 'win32') {