Skip to content
This repository was archived by the owner on Sep 18, 2024. It is now read-only.
This repository was archived by the owner on Sep 18, 2024. It is now read-only.

--dev should not use tags #22

@ian29

Description

@ian29

im trying trying to deploy a branch of dynamosm-operator that uses a dev pacakge of dynamosm, but hitting a Expected version 0.6.0 of dynamosm but found 0.12.1 error from mbx deploy. this is because --dev first gets it's gitsha from git describe --tags rather than just reading package.json: https://github.com/mapbox/npm-internal/blob/master/index.js#L48

i think the ideal behavior would be to always always read the package.json version and never tags (assuming it's unlikely that if you're publishing a dev pkg that you've incremented the tag).

i can do a quickie PR that just removes https://github.com/mapbox/npm-internal/blob/master/index.js#L48 ?

@freenerd @karenzshea

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions