Repository navigation
chore(candidate): build Windows Process Bus Insight binary for SV PCAP acceptance #54
candidate-package.yml
on: pull_request
Build verified Windows x64 candidate
1m 36s
Annotations
20 warnings
|
Build verified Windows x64 candidate:
src/ProcessBus.App.Wpf/ViewModels/MainWindowViewModel.cs#L4344
Use 'string.EndsWith(char)' instead of 'string.EndsWith(string)' when you have a string with a single char (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1865)
|
|
Build verified Windows x64 candidate:
src/ProcessBus.App.Wpf/ViewModels/MainWindowViewModel.cs#L4344
Use 'string.StartsWith(char)' instead of 'string.StartsWith(string)' when you have a string with a single char (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1865)
|
|
Build verified Windows x64 candidate:
src/ProcessBus.App.Wpf/ViewModels/MainWindowViewModel.cs#L4324
The behavior of 'int.ToString()' could vary based on the current user's locale settings. Replace this call in 'GooseTrafficRow.DatasetEntryCountText.get' with a call to 'int.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Build verified Windows x64 candidate:
src/ProcessBus.App.Wpf/ViewModels/MainWindowViewModel.cs#L4320
The behavior of 'DateTime.ToString(string)' could vary based on the current user's locale settings. Replace this call in 'GooseTrafficRow.EntryTimeText.get' with a call to 'DateTime.ToString(string, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Build verified Windows x64 candidate:
src/ProcessBus.App.Wpf/ViewModels/MainWindowViewModel.cs#L4275
The behavior of 'DateTime.ToString(string)' could vary based on the current user's locale settings. Replace this call in 'GooseTrafficRow.TimeText.get' with a call to 'DateTime.ToString(string, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Build verified Windows x64 candidate:
src/ProcessBus.App.Wpf/ViewModels/MainWindowViewModel.cs#L4460
The behavior of 'DateTime.ToString(string)' could vary based on the current user's locale settings. Replace this call in 'TrafficHealthTargetRow.LastSeenText.get' with a call to 'DateTime.ToString(string, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Build verified Windows x64 candidate:
src/ProcessBus.App.Wpf/MainWindow.xaml.cs#L143
The behavior of 'int.ToString()' could vary based on the current user's locale settings. Replace this call in 'MainWindow.UpdateWorkspaceActivePill(bool)' with a call to 'int.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Build verified Windows x64 candidate:
src/ProcessBus.App.Wpf/ViewModels/MainWindowViewModel.cs#L4770
Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1861)
|
|
Build verified Windows x64 candidate:
src/ProcessBus.App.Wpf/ViewModels/MainWindowViewModel.cs#L4541
The behavior of 'int.ToString()' could vary based on the current user's locale settings. Replace this call in 'SclStreamCatalogRow.ExpectedConfRevText.get' with a call to 'int.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Build verified Windows x64 candidate:
src/ProcessBus.App.Wpf/Controls/WaveformPanelControl.cs#L198
In member void WaveformPanelControl.OnRender(DrawingContext dc), change parameter name dc to drawingContext in order to match the identifier as it has been declared in void UIElement.OnRender(DrawingContext drawingContext) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
|
|
Build verified Windows x64 candidate:
src/ProcessBus.Iec61850.Raw/Analysis/RawProcessBusAnalyzer.cs#L247
The behavior of 'uint.ToString()' could vary based on the current user's locale settings. Replace this call in 'RawProcessBusAnalyzer.ResolveSvMappingProfile(ProcessBusFrame, SampledValueAsdu)' with a call to 'uint.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Build verified Windows x64 candidate:
src/ProcessBus.Iec61850.Raw/Analysis/RawProcessBusAnalyzer.cs#L246
The behavior of 'ushort.ToString()' could vary based on the current user's locale settings. Replace this call in 'RawProcessBusAnalyzer.ResolveSvMappingProfile(ProcessBusFrame, SampledValueAsdu)' with a call to 'ushort.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Build verified Windows x64 candidate:
src/ProcessBus.Iec61850.Raw/Decoding/RawProcessBusDecoder.cs#L34
TryDecode calls TryParse but does not explicitly check whether the conversion succeeded. Either use the return value in a conditional statement or verify that the call site expects that the out argument will be set to the default value when the conversion fails. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1806)
|
|
Build verified Windows x64 candidate:
src/ProcessBus.Iec61850.Raw/Decoding/RawProcessBusDecoder.cs#L31
TryDecode calls TryParse but does not explicitly check whether the conversion succeeded. Either use the return value in a conditional statement or verify that the call site expects that the out argument will be set to the default value when the conversion fails. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1806)
|
|
Build verified Windows x64 candidate:
src/ProcessBus.Iec61850.Raw/Decoding/RawProcessBusDecoder.cs#L28
TryDecode calls TryParse but does not explicitly check whether the conversion succeeded. Either use the return value in a conditional statement or verify that the call site expects that the out argument will be set to the default value when the conversion fails. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1806)
|
|
Build verified Windows x64 candidate:
src/ProcessBus.Iec61850.Raw/Runtime/SvRuntimeSnapshot.cs#L169
Use 'ArgumentOutOfRangeException.ThrowIfNegative' instead of explicitly throwing a new exception instance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1512)
|
|
Build verified Windows x64 candidate:
src/ProcessBus.Core/Services/PcapAdapterCatalog.cs#L128
Specify marshaling for P/Invoke string arguments (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2101)
|
|
Build verified Windows x64 candidate:
src/ProcessBus.Core/Services/PcapAdapterCatalog.cs#L58
The behavior of 'int.ToString()' could vary based on the current user's locale settings. Replace this call in 'PcapAdapterCatalog.GetAdaptersCore()' with a call to 'int.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Build verified Windows x64 candidate:
src/ProcessBus.Core/Models/PtpEventItem.cs#L6
The behavior of 'DateTime.ToString(string)' could vary based on the current user's locale settings. Replace this call in 'PtpEventItem.TimeText.get' with a call to 'DateTime.ToString(string, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
Build verified Windows x64 candidate:
src/ProcessBus.Core/Services/Scl/SclSemanticParser.cs#L9
Member 'Load' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
|