Skip to content

User gets credited twice for odd case #56

@ghost

Description

From email:

 I would like to report a bug in the TMSC balance reporting for address 1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6, balance 0.101 which differs from MasterChest, balance 0.082. 

In both cases, the totals add up like so:
 "total_received": "0.12" + "total_bought": "0.004" - total_sent": "0.033" - "total_sold": "0.009" = 0.082

 The reported balance shows a difference of 0.101-0.082=0.019, which is the same available_amount of sell_offer f4d5e7a5af93b50... 

I looked through some debug and found a few odd things, would you happen to find any of this odd? I've highlighted relevant portions in bold.

Balance is credited for the  expired accept that was updated (reserved funds *not* changed)
 1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6 Test Mastercoin before alarm expired 
[D] debug_address: balance: 5100000
[D] debug_address: reserved: 2900000
[D] check_alarm: skip updating reserved on 1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6 as payment expired and it got already updated
1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6 Test Mastercoin after alarm expired 
[D] debug_address: balance: 7000000
[D] debug_address: reserved: 2900000
1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6 Test Mastercoin after alarm expired


And after the final sell cancel:
t1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6 Test Mastercoin before sell offer 
[D] debug_address: balance: 7000000
[D] debug_address: reserved: 2900000
1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6 Test Mastercoin before sell offer 
[D] check_mastercoin_transaction: [u'2ae17011888e9a2e6c752999774cd6d88feb7c0751abe72a602be89858e44f6a']
[D] check_mastercoin_transaction: accept_offer_running NOT exhausted
[D] check_mastercoin_transaction: accept already expired
[D] check_mastercoin_transaction: NO accept offer was running - add all reserved to balance
[D] debug_address: balance: 9900000
[D] debug_address: reserved: 0
1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6 Test Mastercoin after sell offer 

It appears as though the seller address is credited twice with 0.019, can you confirm any of this behavior?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions