Develop#131
Open
coroboX wants to merge 5 commits into
Open
Conversation
DimaDP
approved these changes
May 25, 2020
danheim
suggested changes
May 25, 2020
| */ | ||
| function rleCompress(source) { | ||
| // write code here | ||
| let readOff = ''; |
There was a problem hiding this comment.
Suggested change
| let readOff = ''; | |
| let compressedString = ''; |
Comment on lines
+26
to
+28
| if (source.length < 2) { | ||
| return source; | ||
| } |
There was a problem hiding this comment.
я думаю можно и без этой проверки справиться, она точно нужна?
| } | ||
|
|
||
| for (let i = 0; i < source.length; i++) { | ||
| if (source[i] === currentSymbol) { |
There was a problem hiding this comment.
в первой итерации ты сравниваешь первый элемент с первым элементом, это не нужно
danheim
approved these changes
May 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.