Skip to content

Solution #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
viktoriamyhailiak wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Solution #1055

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c39004b
Solution
viktoriamyhailiak Jan 11, 2026
da96d4c
Solution
viktoriamyhailiak Jan 11, 2026
fc8d1bc
Solution
viktoriamyhailiak Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/splitInteger.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,23 @@ const splitInteger = require('./splitInteger');

test(`should split a number into equal parts
if a value is divisible by a numberOfParts`, () => {

expect(splitInteger(6, 2)).toEqual([3, 3]);
});

test(`should return a part equals to a value
when splitting into 1 part`, () => {

expect(splitInteger(8, 1)).toEqual([8]);
});

test('should sort parts ascending if they are not equal', () => {
expect(splitInteger(32, 6)).toEqual([5, 5, 5, 5, 6, 6]);
});

test('should sort parts ascending if they are not equal', () => {

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test has the same description as the one on line 15. It's a good practice to give each test a unique and descriptive name. This helps identify exactly which test fails if there's an issue. For example, you could change this to something like should split 17 into 4 parts.

expect(splitInteger(17, 4)).toEqual([4, 4, 4, 5]);
});

test('should add zeros if value < numberOfParts', () => {

test('should add zeros if value < numberOfParts', () => {
expect(splitInteger(4, 5)).toEqual([0, 1, 1, 1, 1]);
});
Comment on lines 24 to 26

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great test for an edge case not listed in the requirements. However, your test suite is missing coverage for one of the examples from the description: splitInteger(32, 6). Please add a test for this case to ensure all requirements are covered.

Comment on lines 24 to 26

@mateacademy-ai-mentor mateacademy-ai-mentor Jan 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're almost there! You've covered most of the required examples. Please also add a test case for splitInteger(17, 4) as specified in the task description to complete the task.