Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/splitInteger.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ function splitInteger(value, numberOfParts) {
rest -= part;
}

return parts;
return parts.sort((a, b) => a - b);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: Sorting the parts array before returning it changes the order of the parts, which is not required and will cause test failures if the tests expect the parts in the order they were generated. Please remove the .sort((a, b) => a - b) to return the parts in their original order.

}

module.exports = splitInteger;
8 changes: 4 additions & 4 deletions src/splitInteger.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,18 @@ const splitInteger = require('./splitInteger');

test(`should split a number into equal parts
if a value is divisible by a numberOfParts`, () => {

expect(splitInteger(8, 2)).toEqual([4, 4]);
});

test(`should return a part equals to a value
when splitting into 1 part`, () => {

expect(splitInteger(1000, 1)).toHaveLength(1);
});

test('should sort parts ascending if they are not equal', () => {

expect(splitInteger(10, 3)).toEqual([3, 3, 4]);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: The test expects the result [3, 3, 4] (ascending order), but the function should return the parts in the order they are generated, which would be [4, 3, 3] for splitInteger(10, 3). Update the expected value to match the correct order.

});

test('should add zeros if value < numberOfParts', () => {

expect(splitInteger(4, 5)).toContain(0);
});