Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 108 additions & 1 deletion src/index.js
Original file line number Diff line number Diff line change
@@ -1 +1,108 @@
'use strict';
import express from 'express';
import cors from 'cors';
import { Server } from 'socket.io';

const PORT = process.env.PORT || 3005;
const app = express();

app.use(cors());
app.use(express.json());


const messages = [];

const roomMeta = {};

app.post('/messages', (req, res) => {
const { text, username, messageTime } = req.body;

if (!text || text.trim().length === 0) {
return res.status(400).send('Write something!');
}

const message = {
id: Date.now(),
author: username,
text,
messageTime
};

io.emit('message', message);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: The new message is emitted to all clients but is not added to the messages array. This means that when a client requests the message history (via 'getMessages'), the new message will not be included. You should add the new message to the messages array here to persist it.

messages.push(message);

res.status(200).json({ success: true });
});

const server = app.listen(PORT, () => {
console.log(`Server running at http://localhost:${PORT}/`);
});

const io = new Server(server, {
cors: {
origin: '*',
},
});

io.on('connection', (socket) => {
console.log('a user connected');

socket.on('getMessages', () => {
socket.emit('messages', messages);
});

socket.on('joinToRoom', ({ name }) => {
const roomId = name;

try {
socket.join(roomId);

if (!roomMeta[roomId]) {
roomMeta[roomId] = { roomId, name: name || 'Без названия' };
}

io.emit('roomList', Object.values(roomMeta));

socket.emit('checkRoomResult', { roomId, isMember: true });

socket.to(roomId).emit('message', `Пользователь ${socket.id} присоединился`);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: The 'message' event is emitted to the room both inside the try block and again after the try-catch (line 71). This will result in duplicate notifications to the room when a user joins. You should only emit this event once.

} catch (error) {
console.log(error, 'error');
}
});

socket.on('renameRoom', (roomId, newName) => {
if (roomMeta[roomId]) {
roomMeta[roomId].name = newName;

// Уведомляем комнату
socket.to(roomId).emit('message', `Group was renamed to ${newName}`);

// Обновляем список для всех
io.emit('roomList', Object.values(roomMeta));
}
});

socket.on('checkRoom', (roomId) => {
const isMember = io.sockets.adapter.rooms.get(roomId)?.has(socket.id) || false;
socket.emit('checkRoomResult', { roomId, isMember });
});

socket.on('deleteRoom', (roomName) => {
if (roomMeta[roomName]) {
delete roomMeta[roomName];

io.emit('roomList', Object.values(roomMeta));
}

socket.leave(roomName);
});

socket.on('getRooms', () => {
socket.emit('roomsList', roomMeta);
});

socket.on('disconnect', () => {
console.log('user disconnected');
});
});