Solution#2776
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your Distance class implementation is functionally correct and meets all core requirements. The code passes all functional tests and the arithmetic and comparison operations work as expected. The __mul__ and __truediv__ methods accept float values correctly at runtime, but your type annotations specify num: int and other: int respectively. Per the requirements, these should be num: int | float and other: int | float. While this doesn't break functionality, fixing these annotations will make your code fully compliant with the type specification. Several comparison and arithmetic methods use else blocks after if statements. These could be refactored to use early returns for cleaner code, though this is a minor style improvement rather than a functional issue. The implementation is solid and works correctly—consider the above suggestions as polish rather than blockers.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
|
|
||
| def __mul__(self, num: int) -> Distance: |
There was a problem hiding this comment.
Type annotation specifies int but should be int | float according to requirements (Distance * int/float).
|
|
||
| def __truediv__(self, other: int) -> Distance: |
There was a problem hiding this comment.
Type annotation specifies int but should be int | float according to requirements (Distance / int/float).
| def __lt__(self, other : Distance | int | float) -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km < other.km |
There was a problem hiding this comment.
This violates checklist item #1: avoid unnecessary else statements. Use early return pattern instead.
| def __gt__(self, other: Distance | int | float) -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km > other.km | ||
| else: |
There was a problem hiding this comment.
This violates checklist item #1: avoid unnecessary else statements. Use early return pattern instead.
| def __eq__(self, other: Distance | int | float) -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km == other.km | ||
| else: |
There was a problem hiding this comment.
This violates checklist item #1: avoid unnecessary else statements. Use early return pattern instead.
| def __le__(self, other: Distance | int | float) -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km <= other.km | ||
| else: |
There was a problem hiding this comment.
This violates checklist item #1: avoid unnecessary else statements. Use early return pattern instead.
| def __ge__(self, other: Distance | int | float) -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km >= other.km | ||
| else: |
There was a problem hiding this comment.
This violates checklist item #1: avoid unnecessary else statements. Use early return pattern instead.
2 participants
No description provided.