Implement Distance class#2788
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your Distance class implementation is functionally complete and correct—all required methods (__init__, __str__, __repr__, arithmetic operators, and comparison operators) work as specified. The logic handles both Distance instances and numeric types properly. However, the flake8 linting check is failing due to missing type annotations on all methods and trailing whitespace on blank lines. These are style and formatting issues that block the CI pipeline from running tests. You'll need to add type annotations like def __init__(self, km: float) -> None: to all methods, include return type annotations for special methods, and remove trailing whitespace from blank lines. Once you fix these linting issues, the CI should pass. Your core implementation is solid—the adjustments needed are purely mechanical additions of type hints and whitespace cleanup.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution meets all requirements. The Distance class implementation is complete and correct. All magic methods (__init__, __str__, __repr__, __add__, __iadd__, __mul__, __truediv__, and comparison operators) are properly implemented with the required type annotations using int | float syntax. The code correctly handles both Distance instances and numeric types for arithmetic and comparison operations, and division properly rounds results to 2 decimal places. All checklist items pass without issues.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.