The Ctrl+P Keyboard Sequence Prints the Document, and Interferes with the VSCode Keyboard Binding

[marvhen]

I use Ctrl+P alot to open files, so we really need a way to turn it off in this extension.

[jrandolf]

Fixed in the upcoming release. Added a capture-phase keyboard listener that intercepts Ctrl+P / Cmd+P before pdf.js can handle it, so the print dialog no longer fires.

[cbachhuber]

Thanks @jrandolf! Does the fix work for you? When I hit ctrl+p while viewing a PDF with this extension v0.1.11, the printing dialog appears briefly and is killed right away. Unfortunately, the file selection palette isn't shown afterwards, but nothing happens. So this is in my opinion not useful as-is.

P.S.: as it's implemented at the moment, it printing suppression also catches ctrl+shift+p. It's good that it catches the shortcut, but similar to above, nothing happens. I'd love to have VS Code's default behavior, which opens the command palette (same as pressing F1).

[casamia918]

Still not working. I installed lasted version. But ctrl+p triggers print dialog.