From fa7371192570a52cd9d1cf56521ce52f17efdae1 Mon Sep 17 00:00:00 2001 From: Kyle Sexton <153232337+kyle-sexton@users.noreply.github.com> Date: Wed, 18 Nov 2026 18:28:35 -0500 Subject: [PATCH] chore(ecosystems): drop tool versions copied from ci-workflows lychee's version and checksum come from ci-workflows' lychee-offline action at the commit pr-require-checks.yml pins, and gitleaks' from ci-workflows' gitleaks action, which no job here calls. Drop both tool-pin entries, name the source in the install hints instead of the numbers, drop the note telling a reader to compare the pins after a ci-workflows bump, and remove the empty tool-pin keys. Refs: melodic-software/control-hub#17 Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C --- .claude/ecosystems/bash.yaml | 1 - .claude/ecosystems/cross-cutting.yaml | 9 +++------ .claude/ecosystems/markdown.yaml | 1 - .claude/ecosystems/yaml.yaml | 1 - 4 files changed, 3 insertions(+), 9 deletions(-) diff --git a/.claude/ecosystems/bash.yaml b/.claude/ecosystems/bash.yaml index 84c212b..2eee368 100644 --- a/.claude/ecosystems/bash.yaml +++ b/.claude/ecosystems/bash.yaml @@ -19,6 +19,5 @@ fix-cmd: null code-fix-cmd: null opt-in: "shellcheck and bash -n always apply to CI's two shell files" install-hint: "shellcheck with no version pin: CI uses the shellcheck preinstalled on the ubuntu-24.04 runner image and installs none (pr-require-checks.yml:87, :94-95), so no checksum is verified. winget install ShellCheck.ShellCheck | brew install shellcheck. bash -n needs bash." -tool-pin: {} gates: [] notes: "No tool-pin: CI installs no shellcheck and uses the runner image's, so its version follows the ubuntu-24.04 image (pr-require-checks.yml:87, :94-95). check-cmd passes shellcheck the same two files and no flags, as CI does (:96-97); this repository tracks no .shellcheckrc. check-cmd lints CI's file list, not : no job in this workflow has a path filter (:12-37), so CI runs both steps on every change; the steps read only the two scripts, which these globs select. The file list copies CI's (:97, :100); when CI's list changes, change it here. Deviations: CI's bash -n step is a for loop in a run step with no shell key, which runs under bash -e and stops at the first file that fails (:98-102), and the job stops at its first failing step; check-cmd unrolls the loop, runs shellcheck and both bash -n calls, and fails when any fails. No shfmt: the bundled bash default (claude-code-plugins plugins/toolchain/reference/ecosystems/bash.yaml:7-8) runs shfmt -d and shfmt -w when .editorconfig declares shell style (:9), which this repository's .editorconfig does (.editorconfig:44-48); CI runs no shfmt, so check-cmd and fix-cmd replace those commands and fix-cmd is null. No test-cmd: CI runs no shell tests." diff --git a/.claude/ecosystems/cross-cutting.yaml b/.claude/ecosystems/cross-cutting.yaml index ca82af3..4910513 100644 --- a/.claude/ecosystems/cross-cutting.yaml +++ b/.claude/ecosystems/cross-cutting.yaml @@ -25,11 +25,8 @@ fix-cmd: null code-fix-cmd: null opt-in: "lychee.toml and .gitleaks.toml at the repository root for lychee and gitleaks; the jq checks always apply" install-hint: | - lychee 0.24.2: winget install lycheeverse.lychee | brew install lychee; CI verifies the x86_64-unknown-linux-gnu release archive by SHA-256 1f4e0ef7f6554a6ed33dd7ac144fb2e1bbed98598e7af973042fc5cd43951c9a - gitleaks 8.30.1: winget install Gitleaks.Gitleaks | brew install gitleaks; no CI job here installs it; the gitleaks composite at ci-workflows@594987a verifies the linux_x64 release archive by SHA-256 551f6fc83ea457d62a0d98237cbad105af8d557003051f41f3e7ca7b3f2470eb + lychee, at the version and SHA-256 ci-workflows' lychee-offline action pins at the commit pr-require-checks.yml calls: winget install lycheeverse.lychee | brew install lychee + gitleaks, at the version and SHA-256 ci-workflows' gitleaks action pins: winget install Gitleaks.Gitleaks | brew install gitleaks; no CI job here installs it jq: winget install jqlang.jq | brew install jq; CI uses the jq preinstalled on the ubuntu-24.04 runner image and installs none (pr-require-checks.yml:94-95). -tool-pin: - lychee: "0.24.2" - gitleaks: "8.30.1" gates: [] -notes: "Lint-only: owned by /toolchain:lint. The lychee command, version and checksum are those of ci-workflows' lychee-offline/action.yml at the commit pr-require-checks.yml:119 pins (its `globs`, `config`, `exclude`, `version` and `sha256` input defaults); Dependabot moves that pin to each ci-workflows release, so compare tool-pin with those defaults when a first-party bump merges. The lychee step passes only the input config: lychee.toml (pr-require-checks.yml:118-121), so the defaults '**/*.md' and no --exclude-path apply (the action's `globs` and `exclude` defaults); the glob is single-quoted so lychee expands it, as in CI. jq has no tool-pin: CI uses the runner image's jq (pr-require-checks.yml:94-95). Deviations: CI's jq step runs two jq calls in a run step with no shell key, under bash -e, so it stops at the first failure (:103-106), and the job stops at its first failing step; check-cmd keeps the two separate calls, because one jq call over several files reads them as one stream, so two truncated files could pass together, and runs every check, failing when any fails. No check reads : jq reads its two named manifests and lychee all markdown, as CI does on every change, since no job in this workflow has a path filter (:12-37). The jq file list copies CI's (:105-106); when CI's list changes, change it here. Links span files, so a renamed file or heading breaks links in files the change does not touch. A local run reads the working tree, where lychee can raise findings CI's clean checkout does not: lychee.toml sets hidden = true and a glob input does not honor .gitignore (lychee.toml:11-16), so an untracked *.md is checked unless it sits under a path lychee.toml excludes (:47-58), for example .work/ or .claude/worktrees/. Deviation from CI: gitleaks. No CI job in this repository runs gitleaks; the line keeps the local secret scan that the bundled cross-cutting default would run without this file (claude-code-plugins plugins/toolchain/reference/ecosystems/cross-cutting.yaml:12, opt-in :18, met by the tracked .gitleaks.toml), so these records do not switch a secret scan off. Its command, version and checksum are those of the gitleaks composite at ci-workflows@594987a (v0.39.8), which this repository does not call: gitleaks/scan.sh:113, :136 and :142 with the defaults at gitleaks/action.yml:9, :15 and :30, pins :50 (version) and :55 (checksum). gitleaks scans every file on disk under the repository root, tracked, untracked or git-ignored (a scratch file under .work/ included), and not git history; it does not read . No typos or editorconfig-checker command: without this file the bundled default (cross-cutting.yaml:11, :14) would run both, because their configs, _typos.toml and .editorconfig-checker.json, meet its opt-in (:18); those are standards-synced files that CI deliberately does not re-lint (pr-require-checks.yml:6-10; .github/workflows/pr-check-managed-files-hosted.yml:41-42, :76), and no CI job here runs those tools. lefthook.yml:1-6 pulls git hooks from claude-code-plugins; apart from gitleaks these records follow CI, not a local hook. Checks with no local form: the pull-request contract check (pr-require-checks.yml:145-150, check-contract at the commit it pins) and the result aggregation (:151-170, aggregate-results at the same commit) in the ci-status job (:123-170); they need the pull request. This ci-status job has no draft refusal. Not run locally: the model review lanes pr-review (.github/workflows/pr-review-hosted.yml:74-85) and pr-review-security (.github/workflows/pr-review-security-hosted.yml:67-78), which review the pull request through ci-workflows reusables called at @main, not pinned; both are advisory and skip drafts (pr-review-hosted.yml:37-38, :76-78; pr-review-security-hosted.yml:44-46, :69-71). Not run locally: check-managed-files (pr-check-managed-files-hosted.yml:106-127, check-managed-files@944d346 v0.74.0), which needs a melodic-software/standards checkout and the pull request; it is advisory and not aggregated into ci-status (:20-22). pr-automerge-dependabot (.github/workflows/pr-automerge-dependabot.yml:22-30) checks nothing; it arms auto-merge on a Dependabot pull request (:3-8)." +notes: "Lint-only: owned by /toolchain:lint. The lychee command, version and checksum are those of ci-workflows' lychee-offline/action.yml at the commit pr-require-checks.yml:119 pins (its `globs`, `config`, `exclude`, `version` and `sha256` input defaults); Dependabot moves that pin to each ci-workflows release. The lychee step passes only the input config: lychee.toml (pr-require-checks.yml:118-121), so the defaults '**/*.md' and no --exclude-path apply (the action's `globs` and `exclude` defaults); the glob is single-quoted so lychee expands it, as in CI. jq has no tool-pin: CI uses the runner image's jq (pr-require-checks.yml:94-95). Deviations: CI's jq step runs two jq calls in a run step with no shell key, under bash -e, so it stops at the first failure (:103-106), and the job stops at its first failing step; check-cmd keeps the two separate calls, because one jq call over several files reads them as one stream, so two truncated files could pass together, and runs every check, failing when any fails. No check reads : jq reads its two named manifests and lychee all markdown, as CI does on every change, since no job in this workflow has a path filter (:12-37). The jq file list copies CI's (:105-106); when CI's list changes, change it here. Links span files, so a renamed file or heading breaks links in files the change does not touch. A local run reads the working tree, where lychee can raise findings CI's clean checkout does not: lychee.toml sets hidden = true and a glob input does not honor .gitignore (lychee.toml:11-16), so an untracked *.md is checked unless it sits under a path lychee.toml excludes (:47-58), for example .work/ or .claude/worktrees/. Deviation from CI: gitleaks. No CI job in this repository runs gitleaks; the line keeps the local secret scan that the bundled cross-cutting default would run without this file (claude-code-plugins plugins/toolchain/reference/ecosystems/cross-cutting.yaml:12, opt-in :18, met by the tracked .gitleaks.toml), so these records do not switch a secret scan off. Its command, version and checksum are those of the gitleaks composite at ci-workflows@594987a (v0.39.8), which this repository does not call: gitleaks/scan.sh:113, :136 and :142 with the defaults at gitleaks/action.yml:9, :15 and :30, pins :50 (version) and :55 (checksum). gitleaks scans every file on disk under the repository root, tracked, untracked or git-ignored (a scratch file under .work/ included), and not git history; it does not read . No typos or editorconfig-checker command: without this file the bundled default (cross-cutting.yaml:11, :14) would run both, because their configs, _typos.toml and .editorconfig-checker.json, meet its opt-in (:18); those are standards-synced files that CI deliberately does not re-lint (pr-require-checks.yml:6-10; .github/workflows/pr-check-managed-files-hosted.yml:41-42, :76), and no CI job here runs those tools. lefthook.yml:1-6 pulls git hooks from claude-code-plugins; apart from gitleaks these records follow CI, not a local hook. Checks with no local form: the pull-request contract check (pr-require-checks.yml:145-150, check-contract at the commit it pins) and the result aggregation (:151-170, aggregate-results at the same commit) in the ci-status job (:123-170); they need the pull request. This ci-status job has no draft refusal. Not run locally: the model review lanes pr-review (.github/workflows/pr-review-hosted.yml:74-85) and pr-review-security (.github/workflows/pr-review-security-hosted.yml:67-78), which review the pull request through ci-workflows reusables called at @main, not pinned; both are advisory and skip drafts (pr-review-hosted.yml:37-38, :76-78; pr-review-security-hosted.yml:44-46, :69-71). Not run locally: check-managed-files (pr-check-managed-files-hosted.yml:106-127, check-managed-files@944d346 v0.74.0), which needs a melodic-software/standards checkout and the pull request; it is advisory and not aggregated into ci-status (:20-22). pr-automerge-dependabot (.github/workflows/pr-automerge-dependabot.yml:22-30) checks nothing; it arms auto-merge on a Dependabot pull request (:3-8)." diff --git a/.claude/ecosystems/markdown.yaml b/.claude/ecosystems/markdown.yaml index 4846012..fda7dd2 100644 --- a/.claude/ecosystems/markdown.yaml +++ b/.claude/ecosystems/markdown.yaml @@ -13,6 +13,5 @@ check-cmd: null fix-cmd: null code-fix-cmd: null install-hint: "None: this record runs no command." -tool-pin: {} gates: [] notes: "No command because CI has none for markdown lint. Without this file the bundled markdown default (claude-code-plugins plugins/toolchain/reference/ecosystems/markdown.yaml:7-8) would run markdownlint-cli2 on changed *.md files, because its opt-in, a markdownlint config (:9), is met by .markdownlint-cli2.jsonc; that file is standards-synced (.github/workflows/pr-check-managed-files-hosted.yml:72) and CI deliberately does not re-lint with it (pr-require-checks.yml:6-10). The record is enabled: true with null commands rather than enabled: false: the repository holds markdown, null commands read as not applicable, and false would also drop the lane for code-metrics, which reads enabled (the ecosystem-commands contract README, Consumers). No opt-in key: there is no check-cmd for it to govern. CI's lychee job checks the links and anchors in these files (pr-require-checks.yml:108-121), and that check runs from cross-cutting.yaml." diff --git a/.claude/ecosystems/yaml.yaml b/.claude/ecosystems/yaml.yaml index 50f3692..fe38d38 100644 --- a/.claude/ecosystems/yaml.yaml +++ b/.claude/ecosystems/yaml.yaml @@ -12,6 +12,5 @@ check-cmd: null fix-cmd: null code-fix-cmd: null install-hint: "None: this record runs no command." -tool-pin: {} gates: [] notes: "No command because CI has none for workflow lint. Without this file the bundled yaml default (claude-code-plugins plugins/toolchain/reference/ecosystems/yaml.yaml:8-11) would run actionlint, because its opt-in, GitHub Actions workflows present (:13), is met. The record is enabled: true with null commands rather than enabled: false: the repository holds workflows, null commands read as not applicable, and false would also drop the lane for code-metrics, which reads enabled (the ecosystem-commands contract README, Consumers). No opt-in key: there is no check-cmd for it to govern. The workflows' checks with no local form are listed in cross-cutting.yaml's notes. These globs, the bundled default's, do not select lefthook.yml or docs/conventions/source-control/commit-convention.yml; CI lints neither, so no command is lost."