From 673c5f96403daf8de5a3496def4a493d5ec7adf2 Mon Sep 17 00:00:00 2001 From: Kyle Sexton <153232337+kyle-sexton@users.noreply.github.com> Date: Fri, 13 Nov 2026 15:57:29 -0500 Subject: [PATCH] ci: remove the ci-status mirror job now that CI Status is required The org ci-gate ruleset has required `CI Status` since 2026-11-12T17:07Z. Remove the `report-ci-status` job, which repeated the gate's conclusion under the old check name `ci-status`, the `alias-jobs: ci-status` input with its comment, and the test that pinned the mirror job. The source-control convention, docs/releases.md and the Dependabot automerge comment now name `CI Status` as the required check. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01RMa43ySvw2yzRFMu7Kekcu --- .github/scripts/workflow-pin-metadata.test.cjs | 9 --------- .github/workflows/pr-automerge-dependabot.yml | 2 +- .github/workflows/pr-require-checks.yml | 18 ------------------ docs/conventions/source-control.yaml | 4 ++-- docs/releases.md | 2 +- 5 files changed, 4 insertions(+), 31 deletions(-) diff --git a/.github/scripts/workflow-pin-metadata.test.cjs b/.github/scripts/workflow-pin-metadata.test.cjs index e90cecf..3991be3 100644 --- a/.github/scripts/workflow-pin-metadata.test.cjs +++ b/.github/scripts/workflow-pin-metadata.test.cjs @@ -284,12 +284,3 @@ test("ci-status is the stable gateway for every Go lane", () => { assert.ok(block.includes(" name: CI Status")); assert.ok(block.includes(" if: always()")); }); - -test("report-ci-status mirrors the gateway under its old check name", () => { - const block = jobBlock(workflowSource("pr-require-checks.yml"), "report-ci-status"); - assert.ok(block.includes(" name: ci-status")); - assert.ok(block.includes(" needs: [ci-status]")); - assert.ok(block.includes(" if: ${{ always() }}")); - assert.ok(block.includes(" permissions: {}")); - assert.ok(block.includes(" [ \"$RESULT\" = success ]")); -}); diff --git a/.github/workflows/pr-automerge-dependabot.yml b/.github/workflows/pr-automerge-dependabot.yml index 8913de8..36ca899 100644 --- a/.github/workflows/pr-automerge-dependabot.yml +++ b/.github/workflows/pr-automerge-dependabot.yml @@ -3,7 +3,7 @@ name: PR Automerge Dependabot # Thin caller of the org's reusable that arms GitHub auto-merge (squash) on a # Dependabot pull request bumping only allowlisted GitHub Actions publishers # (`actions/*`, `github/*`, `anthropics/*`) by a patch or minor version. Arming -# never merges: GitHub merges once every required check, `ci-status` included, +# never merges: GitHub merges once every required check, `CI Status` included, # passes. The caller owns the trigger, concurrency and the permission grant; a # called workflow can only downgrade the caller's grant. Runs on the # GitHub-hosted `ubuntu-24.04` runner. diff --git a/.github/workflows/pr-require-checks.yml b/.github/workflows/pr-require-checks.yml index a91c88d..b83b985 100644 --- a/.github/workflows/pr-require-checks.yml +++ b/.github/workflows/pr-require-checks.yml @@ -520,9 +520,6 @@ jobs: if: ${{ !cancelled() }} uses: melodic-software/ci-workflows/.github/actions/pr-require-checks/aggregate-results@9bfbca898bff801f5a8fd3d0f98ae6a0538e4386 # v0.73.0 with: - # report-ci-status mirrors this gate under `ci-status` and runs on - # contract-only events too; the run-shape reads must ignore it. - alias-jobs: ci-status results: >- ${{ needs.markdownlint.result }} ${{ needs.shellcheck.result }} @@ -557,18 +554,3 @@ jobs: # step's own name lets the carry-forward and yield lookups find it. step-name: Aggregate lane results token: ${{ github.token }} - - report-ci-status: - name: ci-status - needs: [ci-status] - if: ${{ always() }} - runs-on: ubuntu-24.04 - timeout-minutes: 3 - permissions: {} - steps: - - name: Report the conclusion of `CI Status` - env: - RESULT: ${{ needs.ci-status.result }} - run: | - echo "CI Status: $RESULT" - [ "$RESULT" = success ] diff --git a/docs/conventions/source-control.yaml b/docs/conventions/source-control.yaml index 6396ad8..f124d67 100644 --- a/docs/conventions/source-control.yaml +++ b/docs/conventions/source-control.yaml @@ -5,10 +5,10 @@ # surface"). The merge-rung ladder and the ratification rule that makes this reviewed file the # recorded baseline: https://github.com/melodic-software/claude-code-plugins/blob/main/docs/contracts/loop-lane/README.md # -# pr_body_required_sections mirrors the body contract the single required check `ci-status` +# pr_body_required_sections mirrors the body contract the single required check `CI Status` # reports on, and that contract is authoritative: .claude/rules/pr-body-contract.md states it in # full, including the closing-keyword (or `No related issue`) requirement this key's grammar cannot -# express. The body contract is advisory, not gating: `ci-status` leaves a comment and the +# express. The body contract is advisory, not gating: `CI Status` leaves a comment and the # `needs-issue-linkage` label instead of failing. The key is a closed literal list of heading names # with no pointer form, so the headings are restated here; never move them independently of that # contract. diff --git a/docs/releases.md b/docs/releases.md index 2bdaded..7e26095 100644 --- a/docs/releases.md +++ b/docs/releases.md @@ -92,7 +92,7 @@ gate validates each Action's current tag and tag-to-commit mapping, the runner tag's GHCR digest, and the runner archive digest against the SHA-256 the runner release notes publish. Minor and patch bumps of `actions/*`, `github/*` and `anthropics/*` Actions take the `vendor-actions` auto-merge lane -(`pr-automerge-dependabot.yml`), which merges once `ci-status` passes; every +(`pr-automerge-dependabot.yml`), which merges once `CI Status` passes; every other update PR is review-only. On a first run, the workflow pushes the BuildKit result without a tag, pulls and