From 3ec00684b35fa4694b6cfb33bc0d9e88283756ac Mon Sep 17 00:00:00 2001 From: Kyle Sexton <153232337+kyle-sexton@users.noreply.github.com> Date: Wed, 18 Nov 2026 18:42:27 -0500 Subject: [PATCH 1/2] fix(repin): skip formal models' checked-commit citations in the leftover check The daily ci-workflows re-pin died on CarryForward.tla, which cites the ci-workflows commit the model was checked against. That citation moves only after the model is re-checked, per its SKILL.md, so the re-pin's leftover check now excludes .claude/skills/formal-*/model/**. Closes #17303 Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C --- scripts/repin-ci-workflows.sh | 3 ++- scripts/repin-ci-workflows.test.sh | 9 +++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/scripts/repin-ci-workflows.sh b/scripts/repin-ci-workflows.sh index fdab47e3c66..dc3a156a9fc 100755 --- a/scripts/repin-ci-workflows.sh +++ b/scripts/repin-ci-workflows.sh @@ -6,6 +6,7 @@ shopt -s inherit_errexit UPSTREAM=melodic-software/ci-workflows # The standards sync owns this file's pin. MANAGED=.github/workflows/pr-check-managed-files-hosted.yml +FORMAL_MODELS='.claude/skills/formal-*/model/**' DOC=docs/conventions/pr-pipeline/pr-run-activity.md SHA_RE='^[0-9a-f]{40}$' TAG_RE='^v[0-9]+\.[0-9]+\.[0-9]+$' @@ -96,7 +97,7 @@ apply() { done <<<"$files" rm -f "$rewritten" - left="$(git -C "$root" grep -l "$old" -- . ":(exclude)${MANAGED}" || true)" + left="$(git -C "$root" grep -l "$old" -- . ":(exclude)${MANAGED}" ":(exclude,glob)${FORMAL_MODELS}" || true)" [[ -z "$left" ]] || die "${old} still appears after the rewrite in: $(tr '\n' ' ' <<<"$left")" outside="$(git -C "$root" status --porcelain | cut -c4- | grep -vxF "$files" || true)" [[ -z "$outside" ]] || die "paths outside the re-pin set changed: $(tr '\n' ' ' <<<"$outside")" diff --git a/scripts/repin-ci-workflows.test.sh b/scripts/repin-ci-workflows.test.sh index 36dfd445270..35969b839e1 100755 --- a/scripts/repin-ci-workflows.test.sh +++ b/scripts/repin-ci-workflows.test.sh @@ -155,4 +155,13 @@ git_test_config "$scratch/left" commit -qm notes run 1 'apply fails when the old SHA remains outside the set' apply "$OLD" v0.74.0 "$NEW" v0.75.0 --root "$scratch/left" contains 'the failure names the file' 'still appears after the rewrite in: tests/notes.md' +mk_repo "$scratch/model" +mkdir -p "$scratch/model/.claude/skills/formal-lanes/model" +echo "\\* checked against ${OLD}" >"$scratch/model/.claude/skills/formal-lanes/model/Lanes.tla" +git_test_config "$scratch/model" add .claude +git_test_config "$scratch/model" commit -qm model +run 0 'apply leaves a formal model citing the old SHA' apply "$OLD" v0.74.0 "$NEW" v0.75.0 --root "$scratch/model" +LAST_OUTPUT="$(cat "$scratch/model/.claude/skills/formal-lanes/model/Lanes.tla")" +contains 'the model keeps its checked commit' "$OLD" + test_harness::report From ee613e8ea33011c8d6ff86458507f80acd12fcc5 Mon Sep 17 00:00:00 2001 From: Kyle Sexton <153232337+kyle-sexton@users.noreply.github.com> Date: Wed, 18 Nov 2026 18:46:11 -0500 Subject: [PATCH 2/2] test(repin): pin the formal-model exclusion to the model directory Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C --- scripts/repin-ci-workflows.test.sh | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/scripts/repin-ci-workflows.test.sh b/scripts/repin-ci-workflows.test.sh index 35969b839e1..5260a0b135a 100755 --- a/scripts/repin-ci-workflows.test.sh +++ b/scripts/repin-ci-workflows.test.sh @@ -164,4 +164,12 @@ run 0 'apply leaves a formal model citing the old SHA' apply "$OLD" v0.74.0 "$NE LAST_OUTPUT="$(cat "$scratch/model/.claude/skills/formal-lanes/model/Lanes.tla")" contains 'the model keeps its checked commit' "$OLD" +mk_repo "$scratch/skilldoc" +mkdir -p "$scratch/skilldoc/.claude/skills/formal-lanes" +echo "pinned at ${OLD}" >"$scratch/skilldoc/.claude/skills/formal-lanes/SKILL.md" +git_test_config "$scratch/skilldoc" add .claude +git_test_config "$scratch/skilldoc" commit -qm skilldoc +run 1 'apply still fails on a formal skill file outside its model' apply "$OLD" v0.74.0 "$NEW" v0.75.0 --root "$scratch/skilldoc" +contains 'the failure names the skill file' 'still appears after the rewrite in: .claude/skills/formal-lanes/SKILL.md' + test_harness::report