From ead4c1939d54e8941d8c686edcb013dd76c70414 Mon Sep 17 00:00:00 2001 From: Kyle Sexton <153232337+kyle-sexton@users.noreply.github.com> Date: Sat, 14 Nov 2026 10:26:51 -0500 Subject: [PATCH] fix: keep the local gitleaks scan in the cross-cutting record The cross-cutting record set no gitleaks command because no CI job here runs one, which switched off the secret scan the bundled toolchain default ran for this repository. Add the scan back as a stated deviation from CI, with the command, version and checksum of the gitleaks composite at ci-workflows v0.39.8, and correct one line cite that moved when the job display names changed. Mark the made-up token in tests/codex-operations.test.mjs with an inline gitleaks:allow comment so the scan passes on a clean tree. Co-Authored-By: Claude Fable 5.2 --- .claude/ecosystems/cross-cutting.yaml | 28 +++++++++++++++++---------- tests/codex-operations.test.mjs | 2 +- 2 files changed, 19 insertions(+), 11 deletions(-) diff --git a/.claude/ecosystems/cross-cutting.yaml b/.claude/ecosystems/cross-cutting.yaml index a6296e8..7a9da86 100644 --- a/.claude/ecosystems/cross-cutting.yaml +++ b/.claude/ecosystems/cross-cutting.yaml @@ -1,23 +1,31 @@ # Repository-wide text checks in this repository. Contract and schema: # https://github.com/melodic-software/claude-code-plugins/tree/main/docs/contracts/ecosystem-commands -# Lint-only: /toolchain:lint runs it, /toolchain:check does not. The one check -# is CI's lychee job (.github/workflows/pr-require-checks.yml:93-106), the -# lychee-offline composite pinned at melodic-software/ci-workflows@594987a -# (v0.39.8) with this repository's lychee.toml (:104-106). The command is the +# Lint-only: /toolchain:lint runs it, /toolchain:check does not. Two checks. +# lychee is CI's lychee job (.github/workflows/pr-require-checks.yml:93-106), +# the lychee-offline composite pinned at melodic-software/ci-workflows@594987a +# (v0.39.8) with this repository's lychee.toml (:104-106); the command is the # composite's arguments (lychee-offline/action.yml:62) with its default glob -# (:8), which it passes to lychee unexpanded (:72-74). Commands run from the -# repository root. +# (:8), which it passes to lychee unexpanded (:72-74). gitleaks is the local +# secret scan, which no CI job here runs; notes give its source. Both run and +# any failure fails the command. Commands run from the repository root. enabled: true globs: ["**"] project-discovery: [] build-cmd: null test-cmd: null -check-cmd: "lychee --offline --no-progress --config lychee.toml '**/*.md'" +check-cmd: | + rc=0 + lychee --offline --no-progress --config lychee.toml '**/*.md' || rc=1 + gitleaks dir . --config .gitleaks.toml --no-banner --redact || rc=1 + test "$rc" -eq 0 fix-cmd: null code-fix-cmd: null -opt-in: "lychee.toml at the repository root" -install-hint: "lychee 0.24.2: winget install lycheeverse.lychee | brew install lychee; CI verifies the x86_64-unknown-linux-gnu release archive by SHA-256 1f4e0ef7f6554a6ed33dd7ac144fb2e1bbed98598e7af973042fc5cd43951c9a" +opt-in: "each tool's own config at the repository root (lychee.toml, .gitleaks.toml)" +install-hint: | + lychee 0.24.2: winget install lycheeverse.lychee | brew install lychee; CI verifies the x86_64-unknown-linux-gnu release archive by SHA-256 1f4e0ef7f6554a6ed33dd7ac144fb2e1bbed98598e7af973042fc5cd43951c9a + gitleaks 8.30.1: winget install Gitleaks.Gitleaks | brew install gitleaks; no CI job here installs it; the gitleaks composite at ci-workflows@594987a verifies the linux_x64 release archive by SHA-256 551f6fc83ea457d62a0d98237cbad105af8d557003051f41f3e7ca7b3f2470eb tool-pin: lychee: "0.24.2" + gitleaks: "8.30.1" gates: [] -notes: "Lint-only: owned by /toolchain:lint. Pins at ci-workflows@594987a: lychee-offline/action.yml:19 (version), :24 (checksum), :40 (asset). CI passes no globs or exclude input (pr-require-checks.yml:105-106), so the defaults '**/*.md' and no --exclude-path apply (action.yml:8, :16). The glob is single-quoted so lychee expands it, as in CI; an unquoted ** in a shell without globstar matches one directory level only. check-cmd checks every markdown file, not : an anchor check spans files, so a changed heading breaks links in files the change does not touch. A local run reads the working tree: lychee.toml sets hidden = true and a glob input does not honor .gitignore, so ignored dot-directories other than the excluded .work/ and .claude/worktrees/ are read too (lychee.toml:11-16, :47-58), which CI's clean checkout does not have. No typos, gitleaks or editorconfig-checker command: _typos.toml, .gitleaks.toml, .editorconfig and .editorconfig-checker.json are standards-synced files (pr-check-managed-files-hosted.yml:41-42, :67, :76), and no CI job here runs those tools; lefthook.yml:1-6 pulls git hooks from claude-code-plugins, and these records follow CI, not a local hook. Checks with no local form: the pull-request contract check (pr-require-checks.yml:130-133, check-contract@594987a v0.39.8) and the result aggregation (:134-153, aggregate-results@ac4d878) in the ci-status job (:108); they need the pull request. This ci-status job has no draft refusal. Not run locally: the model review lanes pr-review (.github/workflows/pr-review-hosted.yml:74-85) and pr-review-security (.github/workflows/pr-review-security-hosted.yml:67-78), which review the pull request through ci-workflows reusables called at @main, not pinned; both are advisory and skip drafts (pr-review-hosted.yml:37-38, :78; pr-review-security-hosted.yml:44-46, :71). Not run locally: check-managed-files (pr-check-managed-files-hosted.yml:106-127, check-managed-files@8e1076f v0.71.0), which needs a melodic-software/standards checkout and the pull request; it is advisory and not aggregated into ci-status (:20-22). pr-automerge-dependabot (.github/workflows/pr-automerge-dependabot.yml:22-28) checks nothing; it arms auto-merge on a Dependabot pull request (:3-7)." +notes: "Lint-only: owned by /toolchain:lint. Pins at ci-workflows@594987a: lychee-offline/action.yml:19 (version), :24 (checksum), :40 (asset). CI passes no globs or exclude input (pr-require-checks.yml:105-106), so the defaults '**/*.md' and no --exclude-path apply (action.yml:8, :16). The glob is single-quoted so lychee expands it, as in CI; an unquoted ** in a shell without globstar matches one directory level only. check-cmd checks every markdown file, not : an anchor check spans files, so a changed heading breaks links in files the change does not touch. A local run reads the working tree: lychee.toml sets hidden = true and a glob input does not honor .gitignore, so ignored dot-directories other than the excluded .work/ and .claude/worktrees/ are read too (lychee.toml:11-16, :47-58), which CI's clean checkout does not have. Deviation from CI: gitleaks. No CI job in this repository runs gitleaks; the line keeps the local secret scan that the bundled cross-cutting default ran before this file existed (claude-code-plugins plugins/toolchain/reference/ecosystems/cross-cutting.yaml:12, opt-in :18, met by the tracked .gitleaks.toml), so these records do not switch a secret scan off. Its command, version and checksum are those of the gitleaks composite at ci-workflows@594987a (v0.39.8), which this repository does not call: gitleaks/scan.sh:113, :136 and :142 with the defaults at gitleaks/action.yml:9, :15 and :30, pins :50 (version) and :55 (checksum). gitleaks scans every file on disk under the repository root, tracked, untracked or git-ignored (a scratch file under .work/ included), and not git history; it does not read . No typos or editorconfig-checker command: _typos.toml, .editorconfig and .editorconfig-checker.json are standards-synced files (pr-check-managed-files-hosted.yml:41-42, :76), and no CI job here runs those tools; lefthook.yml:1-6 pulls git hooks from claude-code-plugins, and apart from gitleaks these records follow CI, not a local hook. Checks with no local form: the pull-request contract check (pr-require-checks.yml:130-133, check-contract@594987a v0.39.8) and the result aggregation (:134-153, aggregate-results@ac4d878) in the ci-status job (:108); they need the pull request. This ci-status job has no draft refusal. Not run locally: the model review lanes pr-review (.github/workflows/pr-review-hosted.yml:74-85) and pr-review-security (.github/workflows/pr-review-security-hosted.yml:67-78), which review the pull request through ci-workflows reusables called at @main, not pinned; both are advisory and skip drafts (pr-review-hosted.yml:37-38, :78; pr-review-security-hosted.yml:44-46, :71). Not run locally: check-managed-files (pr-check-managed-files-hosted.yml:106-127, check-managed-files@8e1076f v0.71.0), which needs a melodic-software/standards checkout and the pull request; it is advisory and not aggregated into ci-status (:20-22). pr-automerge-dependabot (.github/workflows/pr-automerge-dependabot.yml:22-29) checks nothing; it arms auto-merge on a Dependabot pull request (:3-7)." diff --git a/tests/codex-operations.test.mjs b/tests/codex-operations.test.mjs index 214783b..f0594b9 100644 --- a/tests/codex-operations.test.mjs +++ b/tests/codex-operations.test.mjs @@ -203,7 +203,7 @@ const rawJwtToken = [ base64Url('{"sub":"codex-plugins"}'), base64Url("not-a-real-signature"), ].join("."); -const rawGithubToken = "ghp_0123456789abcdefghijABCDEFGHIJ"; +const rawGithubToken = "ghp_0123456789abcdefghijABCDEFGHIJ"; // gitleaks:allow const collectorCases = [ {