From 63e4aa4647f683b02bb04fb044f472aa68515098 Mon Sep 17 00:00:00 2001 From: Kyle Sexton <153232337+kyle-sexton@users.noreply.github.com> Date: Wed, 18 Nov 2026 18:21:23 -0500 Subject: [PATCH] chore(ecosystems): drop tool versions copied from ci-workflows The lychee and gitleaks versions and checksums in cross-cutting.yaml restated ci-workflows' composite-action defaults, which this repository does not override. Hints now name that source without the number, and empty tool-pin keys are gone. node stays pinned: .node-version is owned here. Refs melodic-software/control-hub#17 Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C --- .claude/ecosystems/bash.yaml | 1 - .claude/ecosystems/cross-cutting.yaml | 9 +++------ .claude/ecosystems/markdown.yaml | 1 - .claude/ecosystems/python.yaml | 1 - .claude/ecosystems/yaml.yaml | 1 - 5 files changed, 3 insertions(+), 10 deletions(-) diff --git a/.claude/ecosystems/bash.yaml b/.claude/ecosystems/bash.yaml index fb9b429..231eb3d 100644 --- a/.claude/ecosystems/bash.yaml +++ b/.claude/ecosystems/bash.yaml @@ -13,6 +13,5 @@ check-cmd: null fix-cmd: null code-fix-cmd: null install-hint: "None: this record runs no command." -tool-pin: {} gates: [] notes: "No command because CI has none for shell. Without this file the bundled bash default (claude-code-plugins plugins/toolchain/reference/ecosystems/bash.yaml:7) would run shellcheck and shfmt on a changed shell file: its opt-in says shellcheck always applies to shell files and shfmt applies when .editorconfig declares shell style (:9), which this repository's .editorconfig does (.editorconfig:46-48). The record is enabled: true with null commands rather than enabled: false: the repository holds a shell script, null commands read as not applicable, and false would also drop the lane for code-metrics, which reads enabled (the ecosystem-commands contract README, Consumers). No opt-in key: there is no check-cmd for it to govern. The script's source of truth is melodic-software/standards; check-managed-files, advisory here, fails a pull request that hand-edits it (pr-check-managed-files-hosted.yml:11-22)." diff --git a/.claude/ecosystems/cross-cutting.yaml b/.claude/ecosystems/cross-cutting.yaml index c08b060..1d9c7da 100644 --- a/.claude/ecosystems/cross-cutting.yaml +++ b/.claude/ecosystems/cross-cutting.yaml @@ -23,10 +23,7 @@ fix-cmd: null code-fix-cmd: null opt-in: "each tool's own config at the repository root (lychee.toml, .gitleaks.toml)" install-hint: | - lychee 0.24.2: winget install lycheeverse.lychee | brew install lychee; CI verifies the x86_64-unknown-linux-gnu release archive by SHA-256 1f4e0ef7f6554a6ed33dd7ac144fb2e1bbed98598e7af973042fc5cd43951c9a - gitleaks 8.30.1: winget install Gitleaks.Gitleaks | brew install gitleaks; no CI job here installs it; the gitleaks composite at ci-workflows@594987a verifies the linux_x64 release archive by SHA-256 551f6fc83ea457d62a0d98237cbad105af8d557003051f41f3e7ca7b3f2470eb -tool-pin: - lychee: "0.24.2" - gitleaks: "8.30.1" + lychee at the version ci-workflows' lychee-offline action pins: winget install lycheeverse.lychee | brew install lychee + gitleaks at the version ci-workflows' gitleaks action pins: winget install Gitleaks.Gitleaks | brew install gitleaks; no CI job here installs it gates: [] -notes: "Lint-only: owned by /toolchain:lint. The lychee version, checksum and release asset are those of ci-workflows' lychee-offline/action.yml at the commit pr-require-checks.yml:104 pins (its `version` and `sha256` input defaults and its install step's asset URL); Dependabot moves that pin to each ci-workflows release, so compare tool-pin and install-hint with those defaults when a first-party bump merges. CI passes no globs or exclude input (pr-require-checks.yml:105-106), so the defaults '**/*.md' and no --exclude-path apply (the action's `globs` and `exclude` defaults). The glob is single-quoted so lychee expands it, as in CI; an unquoted ** in a shell without globstar matches one directory level only. check-cmd checks every markdown file, not : an anchor check spans files, so a changed heading breaks links in files the change does not touch. A local run reads the working tree: lychee.toml sets hidden = true and a glob input does not honor .gitignore, so ignored dot-directories other than the excluded .work/ and .claude/worktrees/ are read too (lychee.toml:11-16, :47-58), which CI's clean checkout does not have. Deviation from CI: gitleaks. No CI job in this repository runs gitleaks; the line keeps the local secret scan that the bundled cross-cutting default ran before this file existed (claude-code-plugins plugins/toolchain/reference/ecosystems/cross-cutting.yaml:12, opt-in :18, met by the tracked .gitleaks.toml), so these records do not switch a secret scan off. Its command, version and checksum are those of the gitleaks composite at ci-workflows@594987a (v0.39.8), which this repository does not call: gitleaks/scan.sh:113, :136 and :142 with the defaults at gitleaks/action.yml:9, :15 and :30, pins :50 (version) and :55 (checksum). gitleaks scans every file on disk under the repository root, tracked, untracked or git-ignored (a scratch file under .work/ included), and not git history; it does not read . No typos or editorconfig-checker command: _typos.toml, .editorconfig and .editorconfig-checker.json are standards-synced files (pr-check-managed-files-hosted.yml:41-42, :76), and no CI job here runs those tools; lefthook.yml:1-6 pulls git hooks from claude-code-plugins, and apart from gitleaks these records follow CI, not a local hook. Checks with no local form: the pull-request contract check (pr-require-checks.yml:130-133, check-contract at the commit it pins) and the result aggregation (:134-153, aggregate-results at the same commit) in the ci-status job (:108); they need the pull request. This ci-status job has no draft refusal. Not run locally: the model review lanes pr-review (.github/workflows/pr-review-hosted.yml:74-85) and pr-review-security (.github/workflows/pr-review-security-hosted.yml:67-78), which review the pull request through ci-workflows reusables called at @main, not pinned; both are advisory and skip drafts (pr-review-hosted.yml:37-38, :78; pr-review-security-hosted.yml:44-46, :71). Not run locally: check-managed-files (pr-check-managed-files-hosted.yml:106-127, check-managed-files at the commit :118 pins), which needs a melodic-software/standards checkout and the pull request; it is advisory and not aggregated into ci-status (:20-22). pr-automerge-dependabot (.github/workflows/pr-automerge-dependabot.yml:22-30) checks nothing; it arms auto-merge on a Dependabot pull request (:3-8)." +notes: "Lint-only: owned by /toolchain:lint. The lychee version, checksum and release asset are those of ci-workflows' lychee-offline/action.yml at the commit pr-require-checks.yml:104 pins (its `version` and `sha256` input defaults and its install step's asset URL). CI passes no globs or exclude input (pr-require-checks.yml:105-106), so the defaults '**/*.md' and no --exclude-path apply (the action's `globs` and `exclude` defaults). The glob is single-quoted so lychee expands it, as in CI; an unquoted ** in a shell without globstar matches one directory level only. check-cmd checks every markdown file, not : an anchor check spans files, so a changed heading breaks links in files the change does not touch. A local run reads the working tree: lychee.toml sets hidden = true and a glob input does not honor .gitignore, so ignored dot-directories other than the excluded .work/ and .claude/worktrees/ are read too (lychee.toml:11-16, :47-58), which CI's clean checkout does not have. Deviation from CI: gitleaks. No CI job in this repository runs gitleaks; the line keeps the local secret scan that the bundled cross-cutting default ran before this file existed (claude-code-plugins plugins/toolchain/reference/ecosystems/cross-cutting.yaml:12, opt-in :18, met by the tracked .gitleaks.toml), so these records do not switch a secret scan off. Its command is that of ci-workflows' gitleaks composite, which this repository does not call (gitleaks/scan.sh with the defaults in gitleaks/action.yml); its version and checksum are that action.yml's `version` and `sha256` defaults. gitleaks scans every file on disk under the repository root, tracked, untracked or git-ignored (a scratch file under .work/ included), and not git history; it does not read . No typos or editorconfig-checker command: _typos.toml, .editorconfig and .editorconfig-checker.json are standards-synced files (pr-check-managed-files-hosted.yml:41-42, :76), and no CI job here runs those tools; lefthook.yml:1-6 pulls git hooks from claude-code-plugins, and apart from gitleaks these records follow CI, not a local hook. Checks with no local form: the pull-request contract check (pr-require-checks.yml:130-133, check-contract at the commit it pins) and the result aggregation (:134-153, aggregate-results at the same commit) in the ci-status job (:108); they need the pull request. This ci-status job has no draft refusal. Not run locally: the model review lanes pr-review (.github/workflows/pr-review-hosted.yml:74-85) and pr-review-security (.github/workflows/pr-review-security-hosted.yml:67-78), which review the pull request through ci-workflows reusables called at @main, not pinned; both are advisory and skip drafts (pr-review-hosted.yml:37-38, :78; pr-review-security-hosted.yml:44-46, :71). Not run locally: check-managed-files (pr-check-managed-files-hosted.yml:106-127, check-managed-files at the commit :118 pins), which needs a melodic-software/standards checkout and the pull request; it is advisory and not aggregated into ci-status (:20-22). pr-automerge-dependabot (.github/workflows/pr-automerge-dependabot.yml:22-30) checks nothing; it arms auto-merge on a Dependabot pull request (:3-8)." diff --git a/.claude/ecosystems/markdown.yaml b/.claude/ecosystems/markdown.yaml index 1a93c9c..157346a 100644 --- a/.claude/ecosystems/markdown.yaml +++ b/.claude/ecosystems/markdown.yaml @@ -13,6 +13,5 @@ check-cmd: null fix-cmd: null code-fix-cmd: null install-hint: "None: this record runs no command." -tool-pin: {} gates: [] notes: "No command because CI has none for markdown lint. Without this file the bundled markdown default (claude-code-plugins plugins/toolchain/reference/ecosystems/markdown.yaml:7) would run markdownlint-cli2 on changed *.md files, because its opt-in, a markdownlint config, is met by .markdownlint-cli2.jsonc; that file is standards-synced (pr-check-managed-files-hosted.yml:72) and no CI job here reads it. The record is enabled: true with null commands rather than enabled: false: the repository holds markdown, null commands read as not applicable, and false would also drop the lane for code-metrics, which reads enabled (the ecosystem-commands contract README, Consumers). No opt-in key: there is no check-cmd for it to govern. CI's node tests read markdown, for example docs/official-docs.md and AGENTS.md (tests/documentation-contract.test.mjs:33, :49); CI runs those tests on every change, and a change to only a *.md file runs no local test (typescript.yaml notes that glob gap)." diff --git a/.claude/ecosystems/python.yaml b/.claude/ecosystems/python.yaml index 1294273..49cdaaf 100644 --- a/.claude/ecosystems/python.yaml +++ b/.claude/ecosystems/python.yaml @@ -13,6 +13,5 @@ check-cmd: null fix-cmd: null code-fix-cmd: null install-hint: "None: this record runs no command." -tool-pin: {} gates: [] notes: "No command because CI has none for Python. Without this file the bundled python default (claude-code-plugins plugins/toolchain/reference/ecosystems/python.yaml:13-14) would run uv run pytest -x -q and uv run ruff check . --no-fix && uv run ruff format . --check && uv run pyright.The scripts are tested through node: tests/codex-changelog.test.mjs and tests/codex-operations.test.mjs spawn them (tests/codex-changelog.test.mjs:22-26, tests/codex-operations.test.mjs:21-30), and that suite is typescript.yaml's test-cmd, kept there so one change does not run it twice. A change to only a *.py file therefore runs no test locally, while CI runs the node tests on every full event (pr-require-checks.yml:76, :88-89). The record is enabled: true with null commands rather than enabled: false: null commands read as not applicable and stop the bundled Python default, while false would also drop the Python lane for code-metrics, which reads enabled (the ecosystem-commands contract README, Consumers). No opt-in key: there is no check-cmd for it to govern." diff --git a/.claude/ecosystems/yaml.yaml b/.claude/ecosystems/yaml.yaml index a9d5657..25a7358 100644 --- a/.claude/ecosystems/yaml.yaml +++ b/.claude/ecosystems/yaml.yaml @@ -12,6 +12,5 @@ check-cmd: null fix-cmd: null code-fix-cmd: null install-hint: "None: this record runs no command." -tool-pin: {} gates: [] notes: "No command because CI has none for workflow lint. Without this file the bundled yaml default (claude-code-plugins plugins/toolchain/reference/ecosystems/yaml.yaml:8-9) would run actionlint, because its opt-in, GitHub Actions workflows present, is met. The record is enabled: true with null commands rather than enabled: false: the repository holds workflows, null commands read as not applicable, and false would also drop the lane for code-metrics, which reads enabled (the ecosystem-commands contract README, Consumers). No opt-in key: there is no check-cmd for it to govern. The workflows' CI-only checks are listed in cross-cutting.yaml's notes. The plugins' agents/openai.yaml sidecars are outside these globs; CI's node tests read them (tests/helpers.mjs:39) on every change, and a change to only a sidecar runs no local test (typescript.yaml notes that glob gap)."