From 3c27604c168118968731e6d51bb2c3b72bbcfa45 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Augusto=20C=C3=A9sar?= Date: Wed, 25 Feb 2026 14:36:17 +0100 Subject: [PATCH 1/2] fix: pin worker-build to 0.1.4 ### Description From workers-rs 0.7.0 the worker-build and worker crate have aligned versions, so worker-build must be pinned to the version of worker to avoid build failures. There has been breaking changes to worker-rs since the version that we are using (0.5) that needs further investigation to bump. Mainly the structure of the `build` directory. To make it simple for now and make so that current builds of the project work, I went ahead and locked the worker-build to the latest version that we know for sure was working on this project (by the date of last build), which is 0.1.4. As a follow-up to this PR, we should look into what needs to change for us to be able to bump to worker@^0.7 (and consequentially worker-build@^0.7). Closes SHIP-2520 ### Resources - https://github.com/cloudflare/workers-rs/releases/tag/v0.7.0 - https://crates.io/crates/worker-build/versions --- .github/workflows/ci.yml | 5 ++++- linkup-cli/build.rs | 5 ++++- worker/wrangler.toml.sample | 5 ++++- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2a67eb69..e8d9ecaa 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -62,6 +62,9 @@ jobs: steps: - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@stable - - run: cargo install -q worker-build + # TODO(augustoccesar)[2026-02-25]: From 0.7.0, the worker-build version is aligned + # with the version of the worker crate. When bumping the worker, it needs to also + # bump the worker-build. + - run: cargo install -q worker-build@0.1.4 - run: worker-build --release working-directory: worker diff --git a/linkup-cli/build.rs b/linkup-cli/build.rs index 7d10252e..193d7f05 100644 --- a/linkup-cli/build.rs +++ b/linkup-cli/build.rs @@ -11,7 +11,10 @@ fn main() { let worker_target_dir = Path::new(&out_dir).join("worker-target"); let install_status = Command::new("cargo") - .args(["install", "-q", "worker-build"]) + // TODO(augustoccesar)[2026-02-25]: From 0.7.0, the worker-build version is aligned + // with the version of the worker crate. When bumping the worker, it needs to also + // bump the worker-build. + .args(["install", "-q", "worker-build@0.1.4"]) .current_dir("../worker") .env("CARGO_TARGET_DIR", &worker_target_dir) .status() diff --git a/worker/wrangler.toml.sample b/worker/wrangler.toml.sample index 426d63f4..519a1580 100644 --- a/worker/wrangler.toml.sample +++ b/worker/wrangler.toml.sample @@ -18,4 +18,7 @@ WORKER_TOKEN = "token123" crons = [ "0 12 * * 2-6" ] [build] -command = "cargo install -q worker-build && worker-build --release" +# TODO(augustoccesar)[2026-02-25]: From 0.7.0, the worker-build version is aligned +# with the version of the worker crate. When bumping the worker, it needs to also +# bump the worker-build. +command = "cargo install -q worker-build@0.1.4 && worker-build --release" From 93500b0d00e4e2485ccfac06e6d205fd1b23c305 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Augusto=20C=C3=A9sar?= Date: Wed, 25 Feb 2026 14:46:58 +0100 Subject: [PATCH 2/2] lint: fix Clippy warnings --- linkup-cli/src/commands/deploy/api.rs | 6 ------ linkup-cli/src/services/cloudflare_tunnel.rs | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/linkup-cli/src/commands/deploy/api.rs b/linkup-cli/src/commands/deploy/api.rs index 9cf3b476..a92c1cd5 100644 --- a/linkup-cli/src/commands/deploy/api.rs +++ b/linkup-cli/src/commands/deploy/api.rs @@ -179,12 +179,6 @@ struct CfBinding { // Possibly other fields like namespace_id, secret text, etc. } -#[derive(Serialize, Deserialize, Debug, Clone)] -struct CloudflareErrorInfo { - code: Option, - message: String, -} - #[derive(Deserialize, Debug)] struct KvNamespace { id: String, diff --git a/linkup-cli/src/services/cloudflare_tunnel.rs b/linkup-cli/src/services/cloudflare_tunnel.rs index f1619ac8..60b1e87e 100644 --- a/linkup-cli/src/services/cloudflare_tunnel.rs +++ b/linkup-cli/src/services/cloudflare_tunnel.rs @@ -12,7 +12,7 @@ use hickory_resolver::{ proto::rr::RecordType, TokioAsyncResolver, }; -use log::{debug, error}; +use log::debug; use serde::{Deserialize, Serialize}; use tokio::time::sleep; use url::Url;