Restriction to whole numbers

[designermonkey]

With all the silly little issues I've raised recently, I think that the only genuine one I have is that the limitation of only allowing whole numbers is a wrong decision from a flexibility perspective.

I would like to be able to calculate prices too, not just quantities.

[michael-e]

So you will also need multiplication and compounded interest calculations. :-)

[designermonkey]

Maybe ;o)

Just for now, calculating money to two decimal places would be great. I can do all the maths in xsl, but the storage won't allow me to save the number. I can hack it for this project, but logging it as I think it could be very useful.

Looking through the code, the only limitations are to the count and count-positive keys.

[michael-e]

Give me some hours to wrap my mind around all those additions and changes which have been implemented since I developed the basic idea. I can't say anything of interest right now.

[michael-e]

@designermonkey, @nilshoerrmann: Maybe somebody has a Rested.app test file for me?

[michael-e]

I broke it. This may take a while.

[nilshoerrmann]

What did you break?
And, sorry, I don't have a test file (have been working in Symphony directly).

[michael-e]

First I have to say that it took me less than 2 minutes to find this first bug. :-))

Using a count-positive param and the set-count action, you can set a negative value. While the event's result will be error, the value will still be set.

Still I suggest to wait with fixing things until I have an overview.

[designermonkey]

I thought about this one too, and I think I know where it is happening, so should be able to fix it easily.

[michael-e]

OT: There are two things I really (!) like:

• The XML output is great — the additions and changes introduced by Nils are cool; especially adding the count as an attribute now seems very logical to me.
• The DS editor is cool as well — and I am already sad that it won't work like that for me, in my 2.2.x production system :-(

[nilshoerrmann]

An acclamation with exclamation:
I quit. Good day.

[nilshoerrmann]

So, how do we deal with this request.
I think that using the count for prices is not the right place (that's why the key is called count and not calculate or price).

[michael-e]

We might introduce a delegate (later) which allows to manipulate the items' preprocessing. So you could introduce your own "special keys" using an extension.

I suggest to keep this issue open and come back when all the known bugs have been fixed.

[michael-e]

(I forgot: Passing the items array to another extension using a delegate would also mean that you could introduce your own mathematical rules for "your" keys.)

[nilshoerrmann]

That's a really good idea.

[nilshoerrmann]

To prepare this we should make the check if the given values are integers optional in the code (using some kind of flag in the function call, that can be passed to the delegate and potentially be overwritten by another extension).