Error in register_bundles and register_shared_bundles

[Is-Saiful]

The jobs fail with the following tre cli error

I've checked AAD_TENANT_ID and API_CLIENT_ID, they are correct and defined in the CICD Environment variables

Searching the repository, I have not found references to TEST_ACCOUNT_CLIENT_ID and TEST_ACCOUNT_CLIENT_SECRET so not sure if these are required

[Is-Saiful]

Checking the last issue
#135

There were fairly recent changes to register bundles commands
#124

[marrobi]

Hmm, this is the code:

def get_token(scope_uri, verify) -> str:
    if config.TEST_ACCOUNT_CLIENT_ID != "" and config.TEST_ACCOUNT_CLIENT_SECRET != "":
        # Logging in as an Enterprise Application: Use Client Credentials flow
        credential = ClientSecretCredential(config.AAD_TENANT_ID, config.TEST_ACCOUNT_CLIENT_ID, config.TEST_ACCOUNT_CLIENT_SECRET, connection_verify=verify, authority=cloud.get_aad_authority_fqdn())
        token = credential.get_token(f'{scope_uri}/.default')
    else:
        # Logging in as a User: Use Resource Owner Password Credentials flow
        credential = UsernamePasswordCredential(config.TEST_APP_ID, config.TEST_USER_NAME, config.TEST_USER_PASSWORD, connection_verify=verify, authority=cloud.get_aad_authority_fqdn(), tenant_id=config.AAD_TENANT_ID)
        token = credential.get_token(f'{scope_uri}/user_impersonation')

    return token.token

Might have made mistake removing these from the pipelines. The word TEST_ might have caused some confusion.

[marrobi]

Ignore me, thats the e2e tests. More haste...

[marrobi]

@Is-Saiful are you able to pull this PR branch and give it a test?

Make auth should create these, or follow https://microsoft.github.io/AzureTRE/latest/tre-admins/identities/test-account/#how-to-create

We should update the docs around these being used as part of CD as its come up a few times.

[Is-Saiful]

@Is-Saiful are you able to pull this PR branch and give it a test?

Make auth should create these, or follow https://microsoft.github.io/AzureTRE/latest/tre-admins/identities/test-account/#how-to-create

We should update the docs around these being used as part of CD as its come up a few times.

• Created the Automation Test Account manually on the Portal and saved the client id and secret as CICD Environment Secrets ( TEST_ACCOUNT_CLIENT_ID and TEST_ACCOUNT_CLIENT_SECRET)

• Pulled the changes and running the pipeline

I'll get back to you asap

[Is-Saiful]

register_bundles and register_shared_bundles stages have passed

[marrobi]

Excellent. Thanks, I've merged the fix.

Thanks for reporting.

[Is-Saiful]

No problem
Thanks for the prompt support