Skip to content

Commit 7781f7c

Browse files
committed
Document why QUnit 1.23.1 is vendored and pinned
Explain that 1.23.1 is the last QUnit version supporting IE8 and must not be upgraded, and why it is committed rather than loaded from a CDN.
1 parent f323c4f commit 7781f7c

1 file changed

Lines changed: 23 additions & 0 deletions

File tree

tests/vendor/README.md

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
# Vendored test dependencies
2+
3+
## QUnit 1.23.1 — pinned, do not upgrade
4+
5+
`qunit-1.23.1.js` / `qunit-1.23.1.css` are vendored on purpose.
6+
7+
**1.23.1 is the last QUnit release that supports Internet Explorer 8**, which
8+
this library still targets. Newer QUnit versions drop IE8 (and older) support,
9+
so upgrading would break the test harness on the very browsers we pin this
10+
version for.
11+
12+
These files are committed (rather than pulled from a CDN) so that:
13+
14+
- the test suite runs offline and deterministically;
15+
- there is no runtime dependency on third-party CDN availability or TLS that
16+
IE8 cannot negotiate;
17+
- the exact reviewed code is what executes.
18+
19+
They are **not** published to npm — the package `files` allowlist only ships
20+
`dist/`, `types/`, and the docs/license, so this folder adds nothing to the
21+
installed package size.
22+
23+
Used by [`../SubtleTests.html`](../SubtleTests.html).

0 commit comments

Comments
 (0)