fix: handle closed logging streams in dispose_engine shutdown (#1526)

Co-authored-by: Byrd <lbyrd@CE-MAC-G453Q12CY4.corp.clearedgeit.com>
Co-authored-by: Richard Lundeen <rlundeen@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: 4 people

pyrit/memory/azure_sql_memory.py

@@ -640,7 +640,15 @@ def dispose_engine(self) -> None:
         """
         if self.engine:
             self.engine.dispose()
-            logger.info("Engine disposed successfully.")
+            # During interpreter shutdown, logging handler streams may already be closed,
+            # causing the framework to print "Logging error" to stderr (GH-1520).
+            # Temporarily suppress logging errors for this teardown message.
+            previous_raise = logging.raiseExceptions
+            logging.raiseExceptions = False
+            try:
+                logger.info("Engine disposed successfully.")
+            finally:
+                logging.raiseExceptions = previous_raise
 
     def get_all_embeddings(self) -> Sequence[EmbeddingDataEntry]:
         """

pyrit/memory/sqlite_memory.py

@@ -364,7 +364,15 @@ def dispose_engine(self) -> None:
         """
         if self.engine:
             self.engine.dispose()
-            logger.info("Engine disposed and all connections closed.")
+            # During interpreter shutdown, logging handler streams may already be closed,
+            # causing the framework to print "Logging error" to stderr (GH-1520).
+            # Temporarily suppress logging errors for this teardown message.
+            previous_raise = logging.raiseExceptions
+            logging.raiseExceptions = False
+            try:
+                logger.info("Engine disposed and all connections closed.")
+            finally:
+                logging.raiseExceptions = previous_raise
 
     def export_conversations(
         self,

tests/unit/memory/test_sqlite_memory.py

@@ -1,6 +1,8 @@
 # Copyright (c) Microsoft Corporation.
 # Licensed under the MIT license.
 
+import io
+import logging
 import os
 import uuid
 from collections.abc import Sequence
@@ -670,6 +672,28 @@ def test_get_conversation_stats_batches_multiple_conversations(sqlite_instance):
     assert result[conv_ids[2]].message_count == 3
 
 
+def test_dispose_engine_tolerates_closed_log_stream(sqlite_instance, capsys):
+    """Verify dispose_engine does not raise or emit 'Logging error' when streams are closed (GH-1520)."""
+    pyrit_logger = logging.getLogger("pyrit")
+    prev_level = pyrit_logger.level
+    pyrit_logger.setLevel(logging.INFO)
+
+    stream = io.StringIO()
+    handler = logging.StreamHandler(stream)
+    root = logging.getLogger()
+    root.addHandler(handler)
+
+    try:
+        stream.close()
+        sqlite_instance.dispose_engine()
+    finally:
+        root.removeHandler(handler)
+        pyrit_logger.setLevel(prev_level)
+
+    captured = capsys.readouterr()
+    assert "Logging error" not in captured.err
+
+
 def test_create_engine_uses_static_pool_for_in_memory(sqlite_instance):
     """In-memory databases must use StaticPool so all threads share one database."""
     from sqlalchemy.pool import StaticPool