Skip to content

Commit b5a89f9

Browse files
radicalCopilot
andcommitted
Unify heartbeat interval to 60s across all test steps
Linux test steps were using the default 5s interval while Windows used 60s. Standardize all 4 heartbeat invocations to 60s to reduce log noise consistently. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 79604ed commit b5a89f9

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

.github/workflows/run-tests.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -393,8 +393,8 @@ jobs:
393393
TestsRunningOutsideOfRepo: true
394394
TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX: 'netaspireci.azurecr.io'
395395
run: |
396-
# Start heartbeat monitor in background
397-
${{ github.workspace }}/${{ env.DOTNET_SCRIPT }} ${{ github.workspace }}/tools/scripts/Heartbeat.cs &
396+
# Start heartbeat monitor in background (60s interval to reduce log noise)
397+
${{ github.workspace }}/${{ env.DOTNET_SCRIPT }} ${{ github.workspace }}/tools/scripts/Heartbeat.cs 60 &
398398
HEARTBEAT_PID=$!
399399
400400
# Run tests
@@ -477,8 +477,8 @@ jobs:
477477
PLAYWRIGHT_INSTALLED: ${{ !inputs.enablePlaywrightInstall && 'false' || 'true' }}
478478
TESTCONTAINERS_HUB_IMAGE_NAME_PREFIX: 'netaspireci.azurecr.io'
479479
run: |
480-
# Start heartbeat monitor in background
481-
${{ env.DOTNET_SCRIPT }} ${{ github.workspace }}/tools/scripts/Heartbeat.cs &
480+
# Start heartbeat monitor in background (60s interval to reduce log noise)
481+
${{ env.DOTNET_SCRIPT }} ${{ github.workspace }}/tools/scripts/Heartbeat.cs 60 &
482482
HEARTBEAT_PID=$!
483483
484484
# Run tests

tools/scripts/Heartbeat.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// diagnose runner hangs and disk space issues during tests.
44
//
55
// Usage: dotnet tools/scripts/Heartbeat.cs [interval-seconds]
6-
// Default interval: 5 seconds
6+
// Default interval: 60 seconds
77
//
88
// Example: dotnet tools/scripts/Heartbeat.cs 10
99

@@ -16,7 +16,7 @@
1616
RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? "Windows" :
1717
throw new NotSupportedException("Unsupported OS platform");
1818

19-
var intervalSeconds = args.Length > 0 && int.TryParse(args[0], out var parsed) ? parsed : 5;
19+
var intervalSeconds = args.Length > 0 && int.TryParse(args[0], out var parsed) ? parsed : 60;
2020
var cts = new CancellationTokenSource();
2121

2222
Console.CancelKeyPress += (_, e) =>

0 commit comments

Comments
 (0)