-
Notifications
You must be signed in to change notification settings - Fork 30
Open
Labels
ciContinuous integrationContinuous integrationmaintainer onlymaintenanceMaintenance work, no version bumpMaintenance work, no version bumpsecuritySecurity-related changes or concernsSecurity-related changes or concerns
Description
Summary
The security-scan.yml reusable workflow installs secretlint at runtime via npm install --no-save @secretlint/secretlint-rule-preset-recommend rather than declaring it as a dev dependency in package.json. This creates an implicit, unversioned dependency that can break silently when upstream versions change.
Current State
# .github/workflows/security-scan.yml
- name: Install secretlint
run: npm install --no-save @secretlint/secretlint-rule-preset-recommendAcceptance Criteria
- Add
@secretlint/secretlint-rule-preset-recommendtodevDependenciesinpackage.jsonwith a pinned version - Add
@secretlint/coretodevDependenciesinpackage.jsonwith a pinned version - Update
security-scan.ymlto usenpm cior rely on the existingnode_modulesfrom the install step - Verify
security-scanworkflow passes in a test PR - Update
package-lock.json
References
- PR build(ci): replace MegaLinter with per-tool GitHub Actions lint workflows #240 — MegaLinter replacement
- Issue ci(lint): replace MegaLinter with dedicated per-tool GitHub Actions workflows #235 — Parent issue
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
ciContinuous integrationContinuous integrationmaintainer onlymaintenanceMaintenance work, no version bumpMaintenance work, no version bumpsecuritySecurity-related changes or concernsSecurity-related changes or concerns