Summary
Add PR-time validation for the documentation site so changes under site/** cannot merge with all required checks green while the Pages build is untested until after merge.
Why
During PR cleanup, site dependency PRs (#446, #462, #468) showed that the required PR checks validate Go and the dashboard, but not the Starlight docs site. The Pages workflow does run npm ci and npm run build, but only on push to main, which means a broken site dependency update would be detected after merge.
Suggested approach
- Add a
site build job to an always-reporting PR workflow, or use a path-filter setup with a skip-shim job so required checks do not deadlock on PRs that do not touch site/**.
- Mirror the existing
/web validation pattern where possible.
- Run at least
cd site && npm ci && npm run build; consider adding the existing site Playwright e2e tests as a follow-up or optional job.
Acceptance criteria
- PRs touching
site/**, package-lock.json, or site workflow/config files validate the docs site before merge.
- Non-site PRs still report a successful/skipped site check if the check is required.
- Dependabot site PRs get the same signal before merge that Pages currently provides only after merge.
Summary
Add PR-time validation for the documentation site so changes under
site/**cannot merge with all required checks green while the Pages build is untested until after merge.Why
During PR cleanup, site dependency PRs (#446, #462, #468) showed that the required PR checks validate Go and the dashboard, but not the Starlight docs site. The Pages workflow does run
npm ciandnpm run build, but only onpushtomain, which means a broken site dependency update would be detected after merge.Suggested approach
sitebuild job to an always-reporting PR workflow, or use a path-filter setup with a skip-shim job so required checks do not deadlock on PRs that do not touchsite/**./webvalidation pattern where possible.cd site && npm ci && npm run build; consider adding the existing site Playwright e2e tests as a follow-up or optional job.Acceptance criteria
site/**,package-lock.json, or site workflow/config files validate the docs site before merge.