From b248154748276f508bed3dbcfb33015119638ddd Mon Sep 17 00:00:00 2001 From: midays Date: Tue, 8 Sep 2026 15:33:44 +0300 Subject: [PATCH] Add --plugin-dir flag registration for all tests This adds the --plugin-dir CLI flag to the e2e test framework without implementing any test logic. This allows the Jenkins pipeline to pass the flag to all test runs without causing 'flag provided but not defined' errors. The flag is registered in: - e2e-tests/config/config.go (global variable) - e2e-tests/tests/tier0/e2e_suite_test.go (tier0 flag registration) - e2e-tests/tests/tier1/e2e_suite_test.go (tier1 flag registration) Tests that don't use the plugin directory will simply ignore the flag. Tests that need it (like MTA-819) can access it via config.PluginDir. This is a prerequisite for the BuildConfig to Shipwright plugin support, allowing the pipeline infrastructure to be in place while the full test implementation is reviewed separately. --- e2e-tests/config/config.go | 1 + e2e-tests/tests/tier0/e2e_suite_test.go | 1 + e2e-tests/tests/tier1/e2e_suite_test.go | 1 + 3 files changed, 3 insertions(+) diff --git a/e2e-tests/config/config.go b/e2e-tests/config/config.go index 5242d258..27c5eef9 100644 --- a/e2e-tests/config/config.go +++ b/e2e-tests/config/config.go @@ -18,6 +18,7 @@ var ( CloudStorage string RcloneConfigFile string RcloneConfigSecret string + PluginDir string ) // Validates the --run-as flag value and logs the active mode. diff --git a/e2e-tests/tests/tier0/e2e_suite_test.go b/e2e-tests/tests/tier0/e2e_suite_test.go index 4169175c..28733151 100644 --- a/e2e-tests/tests/tier0/e2e_suite_test.go +++ b/e2e-tests/tests/tier0/e2e_suite_test.go @@ -25,6 +25,7 @@ func init() { flag.StringVar(&config.CloudStorage, "cloud-storage", "", "S3-compatible cloud storage path for indirect transfer (e.g. remote:my-bucket)") flag.StringVar(&config.RcloneConfigFile, "rclone-config-file", "", "Path to local rclone.conf file for indirect transfer") flag.StringVar(&config.RcloneConfigSecret, "rclone-config-secret", "", "K8s Secret name containing rclone.conf for indirect transfer") + flag.StringVar(&config.PluginDir, "plugin-dir", "", "Directory containing crane transform plugins") } var _ = BeforeSuite(func() { diff --git a/e2e-tests/tests/tier1/e2e_suite_test.go b/e2e-tests/tests/tier1/e2e_suite_test.go index ad211e30..ffc9a4b1 100644 --- a/e2e-tests/tests/tier1/e2e_suite_test.go +++ b/e2e-tests/tests/tier1/e2e_suite_test.go @@ -25,6 +25,7 @@ func init() { flag.StringVar(&config.CloudStorage, "cloud-storage", "", "S3-compatible cloud storage path for indirect transfer (e.g. remote:my-bucket)") flag.StringVar(&config.RcloneConfigFile, "rclone-config-file", "", "Path to local rclone.conf file for indirect transfer") flag.StringVar(&config.RcloneConfigSecret, "rclone-config-secret", "", "K8s Secret name containing rclone.conf for indirect transfer") + flag.StringVar(&config.PluginDir, "plugin-dir", "", "Directory containing crane transform plugins") } var _ = BeforeSuite(func() {