Skip to content

Open message links externally#40

Open
yibo365 wants to merge 1 commit into
minghinmatthewlam:mainfrom
yibo365:codex/open-message-links-externally
Open

Open message links externally#40
yibo365 wants to merge 1 commit into
minghinmatthewlam:mainfrom
yibo365:codex/open-message-links-externally

Conversation

@yibo365

@yibo365 yibo365 commented Jun 8, 2026

Copy link
Copy Markdown

Summary

  • route markdown-created web links through Electron's external browser handling
  • prevent external URLs from opening inside the Pi window or creating extra Electron windows
  • add a core Electron spec covering message link clicks

Fixes #20

Verification

  • pnpm --filter @pi-gui/desktop typecheck
  • pnpm --dir apps/desktop exec electron-vite build
  • pnpm --filter @pi-gui/desktop run test:e2e:runner -- apps/desktop/tests/core/external-links.spec.ts
  • git diff --check

Note: pnpm --filter @pi-gui/desktop build is currently blocked in my local environment by xcrun swiftc failing to load the Xcode toolchain while building the notification helper.

@vercel

vercel Bot commented Jun 8, 2026

Copy link
Copy Markdown

@yibo365 is attempting to deploy a commit to the dev Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open external links in the system browser instead of navigating inside Pi UI

1 participant