Bump MJML dependency version

[arokanto]

This package still relies on mjml version ^3.2.2. When installing you get the following warnings:

warning mjml2json > mjml > mjml-cli > chokidar@1.7.0: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
warning mjml2json > mjml > mjml-cli > chokidar > fsevents@1.2.13: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
warning mjml2json > mjml > mjml-button > react > fbjs > core-js@1.2.7: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.

Maybe the mjml dependency should be bumped to something on the 4.x line.

[arokanto]

Any news on this? mjmj 3.2 has 279 low-severity vulnerabilities. All of them are because of outdated versions of node-fetch and ini, which are required by transitive dependencies of mjml 3.2.

Do you have plans to update this module to require mjml 4? For me mjml2json is still a useful module.

[stianjensen]

I tried looking at this, but there are quite a few breaking changes and not all seem to be documented, so it requires some work looking into the internals of mjml: #25

[istr]

I provided #29 that works and replaces #25.

[zhuanyan-wang]

Since the project seemed abandoned, for anyone who doesn't need the CLI tool and wants to use it with MJML 4 without the critical vulnerabilities, here is what you can do for now:

1. Copy mjml2json.js to your project.
2. Install the required dependencies: lodash, htmlparser2, and mjml.
3. Change lines 1 to 23 (see the code snippet below).
4. Import the mjml2json function from your local mjml2json.js.

import _ from "lodash";
import * as htmlparser from "htmlparser2";
import { components } from "mjml-core";

const CDATASections = [];
const MJElements = [];

_.forEach(
  {
    ...components,
  },
  (value, key) => {
    // @ts-ignore - "componentName" exists but the type definition is incomplete currently.
    const tagName = value?.componentName ?? key;

    // @ts-ignore - "endingTag" exists on some components but the type definition is incomplete currently.
    if (value?.endingTag) {
      CDATASections.push(tagName);
    }

    MJElements.push(tagName);
  }
);

Notes:

• Import globalComponents or components? They are the same thing, but components is better because the type definition only recognizes components.
• tagName no longer exists on components, use componentName instead.
• componentName should exist on all components, but keeping the fallback just in case.
• endingTag only exists on some components, use optional chaining.
• @ts-ignore is added to prevent IDEs (when checkJs is set to true) from complaining. The current type definitions for different components are incomplete and don't include all the attributes.
• You can log value and key to see what attributes are available for each component type.

[avneeshkumar]

Since this was not working, we have now forked and created a new repo here with updated dependencies and TS support

https://www.npmjs.com/package/@mailmodo/mjml2json
https://github.com/mailmodo/mjml2json

You can start using the package .