Skip to content

Add support for percentage syntax for width and height options. #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmanley wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for percentage syntax for width and height options. #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6900924
Update jquery.popupwindow.js
Sep 3, 2017
6c6e725
Update README.md
Sep 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ There are more [examples] to look at as well.
|--------------|----------|---------|-------|
| `center` | string | `'screen'`| possible values are: `'screen'`,`'parent'`, and `null`. For backwards compatibility `true`/`false` is still supported, but deprecated, and may be removed in a future version |
| `createNew` | boolean | `true` | open a new window, or re-use existing popup |
| `height` | integer | `500` | |
| `height` | integer | `500` | see `'width'` for syntax notes |
| `left` | integer | `0` | |
| `location` | boolean | `false` | |
| `menubar` | boolean | `false` | |
Expand All @@ -76,7 +76,7 @@ There are more [examples] to look at as well.
| `status` | boolean | `false` | |
| `toolbar` | boolean | `false` | |
| `top` | integer | `0` | |
| `width` | integer | `500` | |
| `width` | integer | `500` | percentages supported too using syntax `'80% of screen'` or `'80% of parent'` or `'80%'` |

## Notes

Expand Down
23 changes: 22 additions & 1 deletion jquery.popupwindow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,33 @@

$.popupWindow = function(url, opts) {
var options = $.extend({}, defaults, opts);

// support deprecated boolean center value
if (options.center === true) {
options.center = "screen";
}

// Convert percentage height (e.g. "80%" or "80% of parent" or "80% of screen") into pixel height.
if ((typeof(options.height) == 'string') && options.height.match(/^(\d+)%(\s+of\s+(screen|opener|parent|window))?$/)) {
var percent = parseInt(RegExp.$1);
var of_what = RegExp.$3 ? RegExp.$3 : (options.center ? options.center : 'screen');
var of_height = of_what == 'screen' ? screen.height : $(window).height();
options.height = Math.round(percent * of_height / 100);
}

// Convert percentage width (e.g. "80%" or "80% of parent" or "80% of screen") into pixel width.
if ((typeof(options.width) == 'string') && options.width.match(/^(\d+)%(\s+of\s+(screen|opener|parent|window))?$/)) {
var percent = parseInt(RegExp.$1);
var of_what = RegExp.$3 ? RegExp.$3 : (options.center ? options.center : 'screen');
var of_width = of_what == 'screen' ? screen.width : $(window).width();
options.width = Math.round(percent * of_width / 100);
}

// center the window
if (options.center === "parent") {
options.top = window.screenY + Math.round(($(window).height() - options.height) / 2);
options.left = window.screenX + Math.round(($(window).width() - options.width) / 2);
} else if (options.center === true || options.center === "screen") {
} else if (options.center === "screen") {
// 50px is a rough estimate for the height of the chrome above the
// document area

Expand Down