Skip to content

Add proper test coverage #19

@mkrl

Description

@mkrl

Is your feature request related to a problem? Please describe.

Every good piece of software has tests. We don't and it's a good chance to have them added.

Describe the solution you'd like

We could start with simple unit tests with the DOM API and terminal instance mocked.
Assert DOM changes being made under different edge cases & conditions. Assert correct instance fields have been mutated & modified. Assert keyboard events performing what they should perform under different conditions, etc.

Additional context

Vitest should be used as a test runner since we're already on Vite.
Here's a checklist:

  1. Write minimal tests covering everything in src/api
  2. Create an npm test script
  3. Hook up into the test GH action workflow (after "Typecheck")

- name: Typecheck
run: npm run typecheck

Not a very trivial task, but we could start a discussion here and work on adding tests together.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesthelp wantedExtra attention is needed

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions