-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Labels
bugSomething (big or small) that gives people troubleSomething (big or small) that gives people troublegood first issueNever contributed to the project before? Start small!Never contributed to the project before? Start small!
Description
Credits to @agrosner for reporting this.
Currently, the value 0 (the standard 'disabled' value for an integer flag) is accepted by CutoutViewIndicator::setOffsetHints(int). Passing that to the function prevents any sort of offset in CutoutImageCell from working, which in turn prevents the indicator from...well, indicating anything.
To make this more transparent, and simpler for new users of the library, I propose two new OffsetHint constants:
- an explicit constant
STOP_EVERYTHINGwith value 0- this'd disable offset-event visual effects
- well, at least until a different value is set on the indicator
- a constant
ONLY_ROUND_NUMBERSwith value 1 << 4- that'd cause cells to only react to OffsetEvents which return an integer from
::getFraction() - ideally some minor rounding to handle floating-point nonsense
- that'd cause cells to only react to OffsetEvents which return an integer from
Also, a new convenience method or two for setting that second flag: not sure on the name(s), but the should have the same vibe as ::justShowTheSelectionsWithoutAnimatingAnything() and ::pleaseGoBackToAnimatingEverything().
Metadata
Metadata
Assignees
Labels
bugSomething (big or small) that gives people troubleSomething (big or small) that gives people troublegood first issueNever contributed to the project before? Start small!Never contributed to the project before? Start small!