Skip to content

Commit cd94506

Browse files
authored
Allow unsigned Windows desktop release (#31)
1 parent 0a8634f commit cd94506

1 file changed

Lines changed: 5 additions & 10 deletions

File tree

.github/workflows/desktop-release.yml

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ jobs:
8585
- name: Set up Node
8686
uses: actions/setup-node@v6
8787
with:
88-
node-version-file: '.nvmrc'
88+
node-version-file: ".nvmrc"
8989

9090
- name: Set up Bun
9191
uses: oven-sh/setup-bun@v2
@@ -187,7 +187,7 @@ jobs:
187187
- name: Set up Node
188188
uses: actions/setup-node@v6
189189
with:
190-
node-version-file: '.nvmrc'
190+
node-version-file: ".nvmrc"
191191

192192
- name: Check out Qwen Code source
193193
if: ${{ inputs.qwen_code_source == 'source_branch' }}
@@ -371,15 +371,10 @@ jobs:
371371
append_env "WIN_CSC_LINK" "$WIN_CSC_LINK_SECRET"
372372
append_env "WIN_CSC_KEY_PASSWORD" "$WIN_CSC_KEY_PASSWORD_SECRET"
373373
else
374-
if ! allow_unsigned_artifacts; then
375-
echo "::error::Published Windows desktop releases require WIN_CSC_LINK and WIN_CSC_KEY_PASSWORD."
376-
exit 1
377-
fi
378-
379-
if [ "$IS_DRY_RUN" = "false" ]; then
380-
echo "::warning::Publishing an unsigned Windows draft release for maintainer testing. Windows may show Unknown Publisher / SmartScreen warnings."
381-
else
374+
if [ "$IS_DRY_RUN" = "true" ]; then
382375
echo "Windows signing certificate is not configured; Windows dry-run artifacts will be unsigned."
376+
else
377+
echo "::warning::Windows signing certificate is not configured; published Windows desktop releases will be unsigned."
383378
fi
384379
fi
385380
else

0 commit comments

Comments
 (0)