Several variables defined at the end of the shutdown_vm function() in utils/tools.py are not properly indented. This causes these variables to be defined at the module level, which are already defined elsewhere. They do not appear to be related to the shutdown function, and it's not clear what the intent is. Perhaps erroneous?
def shutdown_vm(ssh_port=""):
if vm_is_running():
execute_on_vm("poweroff", ssh_port = ssh_port)
time.sleep(2)
if not vm_is_running():
print("VM is powered off")
else:
print("No VM is alive, skip shutdown")
extra_opts=""
wait_flag="nowait"
format="raw"
num_cpus="8"
accel_mode="kvm"
def run_with_dcd_mctp():
---8<---
Since accel_mode is hard coded in this module, it could impact the use of -A tcg in the cxl-tool.py.
If this is unnecessary code, consider removing it.
Several variables defined at the end of the
shutdown_vm function()in utils/tools.py are not properly indented. This causes these variables to be defined at the module level, which are already defined elsewhere. They do not appear to be related to the shutdown function, and it's not clear what the intent is. Perhaps erroneous?Since
accel_modeis hard coded in this module, it could impact the use of-A tcgin thecxl-tool.py.If this is unnecessary code, consider removing it.