Add PvP Toggle to Protector Nodes

[monk-afk]

Add a checkbox to the owner formspec allowing a toggle for enabling PvP within the protected area.

Protector:

• When PvP is enabled, the owner of the protected area must be vulnerable to damage
• When PvP is enabled, disable node interaction (digging/placing) for anyone inside the protected radius, including the owner and members.
• Placer tool does not transfer the checkbox state when crouch is pressed while using the placer.
• Existing bug fixed: using the placer tool doesn't transfer the 'allow factions' state
• Register protector:protect_hidden which can be toggled via command /protector_view [hide|block|logo] with registered alias /pb.

Bones:

• Change bones placement condition from if not protected from this player to if not protected

Bonespos:

• Ensure positions are saved only on successful bones placement.

QA/Testing:

• Protector owner can enable pvp
• PvP State does not transfer using placer while shift/crouch
• Protector owner cannot place or dig within the protected area when PvP is enabled
• Owner of PvP-enabled protected area can take damage
• Neither owner nor guests drop bones while inside protected area, regardless of meta states (faction/pvp)
• Faction members can still access nodes inside a faction-shared protected area
• Faction-shared state transfers when placer tool is used while holding shift/crouch
• Confirm members also transfer
• Confirm /bones command is not over-written if player dies without dropping bones after a bonespos was recorded

[monk-afk]

Problem with this proposal is the "When PvP is enabled, disable node interaction for anyone inside the protected radius, including the owner and members." detail, which could cause the protector owner to become unable to disable PvP if the crouch-placement via placer tool is used. This would transfer the enabled PvP state, potentially through solid nodes; in that case the protector could not be accessed without digging.

Possible workaround may be to disallow the PvP state transfer, requiring the owner to physically enable the PvP state. Placement of nodes while PvP is enabled would prevent barring access to the node.

[monk-afk]

Deployed

[YashuDaKJ]

absolute cinema, We needed him, thank you Monk.!

[monk-afk]

re-opened, feature was rolled back due to suspected cause of lag, will attempt to add again