Can you support objective-c

[BinBear]

Can you support objective-c

[moozzyk]

Will need to figure this out. Looks like a similar issue to #13

[lexiaoyao20]

you can add an adapter to support objective-c, like this.

//
//  SignalRClient.h
//  Followme
//
//  Created by Subo on 2018/12/25.
//  Copyright © 2018年 com.followme. All rights reserved.
//

import Foundation
import SwiftSignalRClient

@objc public protocol SignalRClientDelegate : class {
    func clientDidConnectSuccess(client: SignalRClient)
    func clientDidConnectFailed(client: SignalRClient, error: Error)
    func clientDidClosed(client: SignalRClient, error: Error?)
}

/// 因为SwiftSignalRClient没有做OC的支持，所以这里多包装了一层来支持OC
@objcMembers public class SignalRClient : NSObject {
    var url: String
    var headers: [String: String]?
    
    private var connection: HubConnection?
    public weak var delegate: SignalRClientDelegate?
    
    public init(url: String, headers: [String: String]?) {
        self.url = url
        self.headers = headers
        super.init()
    }
    
    public func start() {
        self.connection = HubConnectionBuilder(url: URL(string: self.url)!)
            .withLogging(minLogLevel: .debug)
            .withHttpConnectionOptions(configureHttpOptions: { (httpConnectionOptions) in
                if let header = self.headers {
                    for (key, value) in header {
                        httpConnectionOptions.headers[key] = value
                    }
                }
            })
            .build()
        self.connection?.delegate = self
        self.connection?.start()
    }
    
    public func stop() {
        self.connection?.stop()
    }
    
    public func on(method: String, callback: @escaping (_ jsonString: String?) -> Void) {
        self.connection?.on(method: method, callback: {args, typeConverter in
            if let json = args.first as? String {
                callback(json)
                return
            }
            callback(nil)
        })
    }
    
    public func send(method: String, arguments:[AnyObject], sendDidComplete: @escaping (_ error: Error?) -> Void) {
        self.connection?.send(method: method, arguments: arguments, sendDidComplete: sendDidComplete)
    }
    
    public func invoke(method: String, arguments: [AnyObject], invocationDidComplete: @escaping (_ error: Error?) -> Void) {
        self.connection?.invoke(method: method, arguments: arguments, invocationDidComplete: invocationDidComplete)
    }
}

extension SignalRClient: HubConnectionDelegate {
    public func connectionDidOpen(hubConnection: HubConnection!) {
        self.delegate?.clientDidConnectSuccess(client: self)
    }
    
    public func connectionDidFailToOpen(error: Error) {
        self.delegate?.clientDidConnectFailed(client: self, error: error)
    }
    
    public func connectionDidClose(error: Error?) {
        self.delegate?.clientDidClosed(client: self, error: error)
    }
}

You can use it like this.

#import "YourTarget-Swift.h"

    NSString *url = @"https://xxxxxxxxxxx";
    NSDictionary *headers = @{@"token" : @"xxxxxxx"};
    self.client = [[SignalRClient alloc] initWithUrl:url headers:headers];
    self.client.delegate = self;
    
    __weak __typeof(self)weakSelf = self;
    [self.client onMethod:@"YourMethod" callback:^(NSString * _Nullable jsonString) {
        NSLog(@"arguments: %@", jsonString);
    }];

    [self.client start];

[moozzyk]

@lexiaoyao20 - this is cool!

[moozzyk]

@lexiaoyao20 - do you mind if I use your code as part of this project?

[lexiaoyao20]

@lexiaoyao20 - do you mind if I use your code as part of this project?

NO problem.

[moozzyk]

Thanks!

…

On Wed, May 29, 2019 at 7:07 AM lexiaoyao20 ***@***.***> wrote: @lexiaoyao20 <https://github.com/lexiaoyao20> - do you mind if I use your code as part of this project? NO problem. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#37?email_source=notifications&email_token=AAK7JJDWHIXOOHYKXQJQ4YDPX2E2NA5CNFSM4GHXUP22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWPOGTA#issuecomment-496952140>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAK7JJCHWHPWF3UUU5USZGDPX2E2NANCNFSM4GHXUP2Q> .

[jaragones]

I am trying to use SignalR-Client-Swift library on an objective C project when calling "start()". I'm getting next error.

2019-08-05T14:02:42.027Z debug: Negotiate response: {"connectionId":"9zjIAJuJmXkN9xLaGrwm3w","availableTransports":[{"transport":"WebSockets","transferFormats":["Text","Binary"]},{"transport":"ServerSentEvents","transferFormats":["Text"]},{"transport":"LongPolling","transferFormats":["Text","Binary"]}]}
2019-08-05T14:02:42.031Z debug: Negotation response received
2019-08-05T14:02:42.033Z info: Starting WebSocket transport
atos[69262]: atos cannot examine process 69257 (ProjectName) for unknown reasons, even though it appears to exist; try running with `sudo`.
==69257==WARNING: Can't read from symbolizer at fd 31
atos[69263]: atos cannot examine process 69257 (ProjectName) for unknown reasons, even though it appears to exist; try running with `sudo`.
==69257==WARNING: Can't read from symbolizer at fd 31
atos[69264]: atos cannot examine process 69257 (ProjectName) for unknown reasons, even though it appears to exist; try running with `sudo`.
==69257==WARNING: Can't read from symbolizer at fd 31
atos[69265]: atos cannot examine process 69257 (ProjectName) for unknown reasons, even though it appears to exist; try running with `sudo`.
==69257==WARNING: Can't read from symbolizer at fd 31
==69257==WARNING: Failed to use and restart external symbolizer!
==================
WARNING: ThreadSanitizer: Swift access race (pid=69257)
  Modifying access of Swift variable at 0x7b280002a280 by thread T10:
    #0 $s18SwiftSignalRClient7Manager33_7B38D54E3FC021D04F957FB8C00AFD21LLCADycfcyycfU_ <null> (SwiftSignalRClient:x86_64+0xd8692)
    #1 $s18SwiftSignalRClient7Manager33_7B38D54E3FC021D04F957FB8C00AFD21LLCADycfcyycfU_TA <null> (SwiftSignalRClient:x86_64+0xe474d)
    #2 $sIeg_IeyB_TR <null> (SwiftSignalRClient:x86_64+0x72460)
    #3 __tsan::invoke_and_release_block(void*) <null> (libclang_rt.tsan_iossim_dynamic.dylib:x86_64+0x676ab)
    #4 _dispatch_client_callout <null> (libdispatch.dylib:x86_64+0x3db4)

  Previous modifying access of Swift variable at 0x7b280002a280 by thread T11:
    #0 $s18SwiftSignalRClient7Manager33_7B38D54E3FC021D04F957FB8C00AFD21LLC6nextIdSiyF <null> (SwiftSignalRClient:x86_64+0xda53b)
    #1 $s18SwiftSignalRClient9WebSocketC7request12subProtocolsAC10Foundation10URLRequestV_SaySSGtcfc <null> (SwiftSignalRClient:x86_64+0xdc2a8)
    #2 $s18SwiftSignalRClient9WebSocketC7request12subProtocolsAC10Foundation10URLRequestV_SaySSGtcfC <null> (SwiftSignalRClient:x86_64+0xdbf92)
    #3 $s18SwiftSignalRClient19WebsocketsTransportC5start3url7optionsy10Foundation3URLV_AA21HttpConnectionOptionsCtF <null> (SwiftSignalRClient:x86_64+0xe9f72)
    #4 $s18SwiftSignalRClient19WebsocketsTransportCAA0E0A2aDP5start3url7optionsy10Foundation3URLV_AA21HttpConnectionOptionsCtFTW <null> (SwiftSignalRClient:x86_64+0xeeaa8)
    #5 $s18SwiftSignalRClient14HttpConnectionC14startTransport33_1386C1C9AB3A1F54B5B7C070283F4473LL19negotiationResponseyAA011NegotiationR0C_tF <null> (SwiftSignalRClient:x86_64+0xffc7)
    #6 $s18SwiftSignalRClient14HttpConnectionC5startyyFyAA19NegotiationResponseCcfU_ <null> (SwiftSignalRClient:x86_64+0xbddf)
    #7 $s18SwiftSignalRClient14HttpConnectionC5startyyFyAA19NegotiationResponseCcfU_TA <null> (SwiftSignalRClient:x86_64+0x15e78)
    #8 $s18SwiftSignalRClient14HttpConnectionC9negotiate33_1386C1C9AB3A1F54B5B7C070283F4473LL11accessToken0F11DidCompleteySSSg_yAA19NegotiationResponseCctFyAA0dU0CSg_s5Error_pSgtcfU0_ <null> (SwiftSignalRClient:x86_64+0xd558)
    #9 $s18SwiftSignalRClient14HttpConnectionC9negotiate33_1386C1C9AB3A1F54B5B7C070283F4473LL11accessToken0F11DidCompleteySSSg_yAA19NegotiationResponseCctFyAA0dU0CSg_s5Error_pSgtcfU0_TA <null> (SwiftSignalRClient:x86_64+0x18dbc)
    #10 $s18SwiftSignalRClient17DefaultHttpClientC04sendE7Request3url6method17completionHandlery10Foundation3URLV_SSyAA0E8ResponseCSg_s5Error_pSgtctFyAH4DataVSg_So13NSURLResponseCSgAOtcfU_ <null> (SwiftSignalRClient:x86_64+0x3c47)
    #11 $s18SwiftSignalRClient17DefaultHttpClientC04sendE7Request3url6method17completionHandlery10Foundation3URLV_SSyAA0E8ResponseCSg_s5Error_pSgtctFyAH4DataVSg_So13NSURLResponseCSgAOtcfU_TA <null> (SwiftSignalRClient:x86_64+0x47e8)
    #12 $s10Foundation4DataVSgSo13NSURLResponseCSgs5Error_pSgIegggg_So6NSDataCSgAGSo7NSErrorCSgIeyByyy_TR <null> (SwiftSignalRClient:x86_64+0x3e18)
    #13 __75-[__NSURLSessionLocal taskForClass:request:uploadFile:bodyData:completion:]_block_invoke <null> (CFNetwork:x86_64+0xc177)
    #14 _dispatch_client_callout <null> (libdispatch.dylib:x86_64+0x3db4)

  Location is heap block of size 160 at 0x7b280002a260 allocated by thread T11:
    #0 malloc <null> (libclang_rt.tsan_iossim_dynamic.dylib:x86_64+0x4a4fa)
    #1 swift_slowAlloc <null> (libswiftCore.dylib:x86_64+0x2ce3c8)
    #2 globalinit_33_7B38D54E3FC021D04F957FB8C00AFD21_func5 <null> (SwiftSignalRClient:x86_64+0xdab37)
    #3 dispatch_once <null> (libclang_rt.tsan_iossim_dynamic.dylib:x86_64+0x682d4)
    #4 dispatch_once_f <null> (libclang_rt.tsan_iossim_dynamic.dylib:x86_64+0x683c0)
    #5 swift_once <null> (libswiftCore.dylib:x86_64+0x2f0578)
    #6 $s18SwiftSignalRClient9WebSocketC7request12subProtocolsAC10Foundation10URLRequestV_SaySSGtcfc <null> (SwiftSignalRClient:x86_64+0xdc267)
    #7 $s18SwiftSignalRClient9WebSocketC7request12subProtocolsAC10Foundation10URLRequestV_SaySSGtcfC <null> (SwiftSignalRClient:x86_64+0xdbf92)
    #8 $s18SwiftSignalRClient19WebsocketsTransportC5start3url7optionsy10Foundation3URLV_AA21HttpConnectionOptionsCtF <null> (SwiftSignalRClient:x86_64+0xe9f72)
    #9 $s18SwiftSignalRClient19WebsocketsTransportCAA0E0A2aDP5start3url7optionsy10Foundation3URLV_AA21HttpConnectionOptionsCtFTW <null> (SwiftSignalRClient:x86_64+0xeeaa8)
    #10 $s18SwiftSignalRClient14HttpConnectionC14startTransport33_1386C1C9AB3A1F54B5B7C070283F4473LL19negotiationResponseyAA011NegotiationR0C_tF <null> (SwiftSignalRClient:x86_64+0xffc7)
    #11 $s18SwiftSignalRClient14HttpConnectionC5startyyFyAA19NegotiationResponseCcfU_ <null> (SwiftSignalRClient:x86_64+0xbddf)
    #12 $s18SwiftSignalRClient14HttpConnectionC5startyyFyAA19NegotiationResponseCcfU_TA <null> (SwiftSignalRClient:x86_64+0x15e78)
    #13 $s18SwiftSignalRClient14HttpConnectionC9negotiate33_1386C1C9AB3A1F54B5B7C070283F4473LL11accessToken0F11DidCompleteySSSg_yAA19NegotiationResponseCctFyAA0dU0CSg_s5Error_pSgtcfU0_ <null> (SwiftSignalRClient:x86_64+0xd558)
    #14 $s18SwiftSignalRClient14HttpConnectionC9negotiate33_1386C1C9AB3A1F54B5B7C070283F4473LL11accessToken0F11DidCompleteySSSg_yAA19NegotiationResponseCctFyAA0dU0CSg_s5Error_pSgtcfU0_TA <null> (SwiftSignalRClient:x86_64+0x18dbc)
    #15 $s18SwiftSignalRClient17DefaultHttpClientC04sendE7Request3url6method17completionHandlery10Foundation3URLV_SSyAA0E8ResponseCSg_s5Error_pSgtctFyAH4DataVSg_So13NSURLResponseCSgAOtcfU_ <null> (SwiftSignalRClient:x86_64+0x3c47)
    #16 $s18SwiftSignalRClient17DefaultHttpClientC04sendE7Request3url6method17completionHandlery10Foundation3URLV_SSyAA0E8ResponseCSg_s5Error_pSgtctFyAH4DataVSg_So13NSURLResponseCSgAOtcfU_TA <null> (SwiftSignalRClient:x86_64+0x47e8)
    #17 $s10Foundation4DataVSgSo13NSURLResponseCSgs5Error_pSgIegggg_So6NSDataCSgAGSo7NSErrorCSgIeyByyy_TR <null> (SwiftSignalRClient:x86_64+0x3e18)
    #18 __75-[__NSURLSessionLocal taskForClass:request:uploadFile:bodyData:completion:]_block_invoke <null> (CFNetwork:x86_64+0xc177)
    #19 _dispatch_client_callout <null> (libdispatch.dylib:x86_64+0x3db4)

  Thread T10 (tid=8726874, running) is a GCD worker thread

  Thread T11 (tid=8726875, running) is a GCD worker thread

SUMMARY: ThreadSanitizer: Swift access race (/Users/jordi/Library/Developer/CoreSimulator/Devices/B4868C29-CDA6-4EDE-BF04-03708A1A4B93/data/Containers/Bundle/Application/82AD19DA-C3E3-424F-80FF-8507A25D3134/ProjectName.app/Frameworks/SwiftSignalRClient.framework/SwiftSignalRClient:x86_64+0xd8692) in $s18SwiftSignalRClient7Manager33_7B38D54E3FC021D04F957FB8C00AFD21LLCADycfcyycfU_
==================
atos[69266]: atos cannot examine process 69257 (ProjectName) for unknown reasons, even though it appears to exist; try running with `sudo`.

@lexiaoyao20 or @moozzyk did you find a similar issue? Any tip would be appreciated!

[moozzyk]

Seems like a data race in the WebSocket library. The stack trace points to this code:

SignalR-Client-Swift/Sources/SignalRClient/WebSocket.swift

Lines 1651 to 1656 in 9e235dc

	func nextId() -> Int {
	pthread_mutex_lock(&mutex)
	defer { pthread_mutex_unlock(&mutex) }
	_nextId += 1
	return _nextId
	}

but I don't immediately see anything there. I think the problem is that I don't know what code the other thread is running:
$s18SwiftSignalRClient7Manager33_7B38D54E3FC021D04F957FB8C00AFD21LLCADycfcyycfU_ (SwiftSignalRClient:x86_64+0xd8692)

[jaragones]

I tried with a new obj-c project with just this pod, so no "external" code is involved, and either worked. From some checking what it comes to my mind is that some of the calls/structures (for example, mutex) are not fully supported by obj-c and that it is what is causing the "Swift access race".

[jaragones]

If anyone interested, there is a pull request for the WebSocket.swift file on its original repo, that solves this issue. Pull request: tidwall/SwiftWebSocket#141

[moozzyk]

@jaragones - this is a great find. My experience is that the SwiftWebSocket project is not actively maintained and PRs linger for a long time before they are merged (if ever). Fortunately, I forked the code so can take the fix without waiting for it to be merged in the SwiftWebSocket repo.

[jaragones]

Cool! Thanks for the library by the way! :)

[moozzyk]

I applied the fix from the PR so if you try master you should no longer see the TSAN issue.

[moozzyk]

@jaragones - the version on CocoaPods now has the TSAN fix.