Skip to content

Disabling Jetstream's Features::api() silently skips 3 API-token test files on every CI run, forever #154

Description

@morcen

What: Three test files each begin their only test method with if (! Features::hasApiFeatures()) { $this->markTestSkipped(...); }. Since Jetstream's Features::api() is commented out/disabled, hasApiFeatures() always returns false, so all three tests unconditionally skip on every run.

Where:

Why it matters: php artisan test reports these as "skipped," not failing, so this has gone unnoticed — but the net effect is zero executed test coverage for API token creation, deletion, or permission updates, despite three files that look like they cover exactly that. This is distinct from #93 itself (which is about the disabled feature breaking the documented REST API's ability to issue tokens) — this issue is the specific, silent test-coverage blind spot that decision creates in CI.

Suggested fix: Once #93 is resolved (API features enabled), these tests will start running for real. Until then, make the skip visible — e.g. a CI summary step that fails/warns if skipped-test count exceeds a threshold, or a README/test-suite note flagging that this coverage is currently dark — so a future regression in these tests can't hide behind a silent skip.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions