Skip to content

Project-rename cleanup missed docker/validate.sh and DEVELOPMENT.md — both fail on first use #167

Description

@morcen

What

PR #134 (commit 6fef967) updated repository references after the project rename from "Webhook Management Platform" to "hooketh", but only touched CONTRIBUTING.md/README.md. Several other files still reference the old name/path and are broken as a result:

  • docker/validate.sh:164if docker images | grep -q webhook-management-platform; then can never match. docker-compose.yml builds/tags images from the actual directory name (hooketh, e.g. hooketh-app), so this check always falls through to the warning branch: make validate (or running the script directly) will print "Application Docker images not found. Run 'make build' to build them." even immediately after a clean, successful build.
  • DEVELOPMENT.md:39-40:
    git clone https://github.com/morcen/hooketh.git
    cd webhook-management-platform
    
    The very first two commands in the quick-start guide fail — the cloned directory is hooketh, not webhook-management-platform. Any new contributor following this doc verbatim gets a No such file or directory before they run a single other command.

Other docs likely carry the same stale branding/paths and are worth a sweep in the same pass: LARAVEL-CLOUD.md, DEVELOPMENT-SETUP.md, ARCHITECTURE.md, scripts/verify-deployment.sh.

Why it matters

docker/validate.sh is the sanity-check script make validate runs to confirm the stack is healthy; it now always reports a false negative for "images built," undermining trust in the script for every future run. DEVELOPMENT.md is the first thing a new contributor opens — its opening commands not working is a bad first impression and wastes their time debugging a "cd: no such file" error that has nothing to do with their environment.

Suggested fix

  • docker/validate.sh:164: replace the hardcoded webhook-management-platform string with a check against the actual compose project name (e.g. docker images | grep -q "^hooketh-" or derive the project name dynamically via basename "$(pwd)" / docker compose config --images).
  • DEVELOPMENT.md:40: change cd webhook-management-platform to cd hooketh.
  • Grep the whole repo for webhook-management-platform / Webhook Management Platform outside of intentionally-historical contexts (e.g. grep -rln "webhook-management-platform" --include="*.md" --include="*.sh" .) and fix any remaining stale references in one follow-up pass.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdocumentationImprovements or additions to documentation

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions