Skip to content

log and lint addon id and version from xpi SignFile #773

Description

@g-k

Follow up items from comments and original issue:

  • return parsed ID and version to SignFile in xpi
    • log parsed ID and version with the "signing operation succeeded" lines instead of from the repacking code
    • when signing in mode ModeAddOn and ModeAddOnWithRecommendation check the lints:
      • warn for a missing manifest.json file
      • warn for multiple IDs: applications.gecko.id and browser_specific_settings.gecko.id
      • warn for manifest ID not matching request Options.ID
      • warn for a missing version

Warnings return errors if we want to do more linting in autograph and other web extension signers pass for legitimate uses.

Originally posted by @g-k in #771 (comment)

┆Issue is synchronized with this Jira Task

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions